From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Rowan Hart <rowanbhart@gmail.com>, qemu-devel@nongnu.org
Cc: "Zhao Liu" <zhao1.liu@intel.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Alexandre Iooss" <erdnaxe@crans.org>
Subject: Re: [PATCH v11 3/8] plugins: Add enforcement of QEMU_PLUGIN_CB flags in register R/W callbacks
Date: Wed, 11 Jun 2025 11:59:01 -0700 [thread overview]
Message-ID: <c6882c95-d1c8-436d-b4be-889f399f4867@linaro.org> (raw)
In-Reply-To: <20250609193841.348076-4-rowanbhart@gmail.com>
On 6/9/25 12:38 PM, Rowan Hart wrote:
> This patch adds functionality to enforce the requested QEMU_PLUGIN_CB_
> flags level passed when registering a callback function using the
> plugins API. Each time a callback is about to be invoked, a thread-local
> variable will be updated with the level that callback requested. Then,
> called API functions (in particular, the register read and write API)
> will call qemu_plugin_get_cb_flags() to check the level is at least the
> level they require.
>
> Signed-off-by: Rowan Hart <rowanbhart@gmail.com>
> ---
> accel/tcg/plugin-gen.c | 30 ++++++++++++++++++++++++++++++
> include/hw/core/cpu.h | 1 +
> include/qemu/plugin.h | 15 +++++++++++++++
> include/qemu/qemu-plugin.h | 19 +++++++++++++------
> plugins/api.c | 4 ++++
> plugins/core.c | 33 +++++++++++++++++++++++++++++++++
> 6 files changed, 96 insertions(+), 6 deletions(-)
Looks good now,
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2025-06-11 19:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 19:38 [PATCH v11 0/8] Add additional plugin API functions to read and write memory and registers Rowan Hart
2025-06-09 19:38 ` [PATCH v11 1/8] gdbstub: Expose gdb_write_register function to consumers of gdbstub Rowan Hart
2025-06-09 19:38 ` [PATCH v11 2/8] plugins: Add register write API Rowan Hart
2025-06-09 19:38 ` [PATCH v11 3/8] plugins: Add enforcement of QEMU_PLUGIN_CB flags in register R/W callbacks Rowan Hart
2025-06-11 18:59 ` Pierrick Bouvier [this message]
2025-06-09 19:38 ` [PATCH v11 4/8] plugins: Add memory virtual address write API Rowan Hart
2025-06-09 19:38 ` [PATCH v11 5/8] plugins: Add memory hardware address read/write API Rowan Hart
2025-06-09 19:38 ` [PATCH v11 6/8] plugins: Add patcher plugin and test Rowan Hart
2025-06-11 20:04 ` Pierrick Bouvier
2025-06-09 19:38 ` [PATCH v11 7/8] plugins: Add hypercalls " Rowan Hart
2025-06-11 19:26 ` Pierrick Bouvier
2025-06-11 22:50 ` Rowan Hart
2025-06-09 19:38 ` [PATCH v11 8/8] plugins: Update plugin version and add notes Rowan Hart
2025-06-11 18:59 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6882c95-d1c8-436d-b4be-889f399f4867@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rowanbhart@gmail.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).