From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Hanna Reitz <hreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, jsnow@redhat.com
Subject: Re: [PATCH v4 18/19] iotests.py: implement unsupported_imgopts
Date: Thu, 23 Dec 2021 17:44:46 +0300 [thread overview]
Message-ID: <c68e6209-2939-d0b2-aa48-77e45c7003bb@virtuozzo.com> (raw)
In-Reply-To: <f93baaa5-7d05-5a59-d439-c4a7e99e48bd@redhat.com>
23.12.2021 15:41, Hanna Reitz wrote:
> On 03.12.21 14:07, Vladimir Sementsov-Ogievskiy wrote:
>> We have added support for some addition IMGOPTS in python iotests like
>> in bash iotests. Similarly to bash iotests, we want a way to skip some
>> tests which can't work with specific IMGOPTS.
>>
>> Globally for python iotests we now don't support things like
>> 'data_file=$TEST_IMG.ext_data_file' in IMGOPTS, so, forbid this
>> globally in iotests.py.
>>
>> Suggested-by: Hanna Reitz <hreitz@redhat.com>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>> tests/qemu-iotests/iotests.py | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> Reviewed-by: Hanna Reitz <hreitz@redhat.com>
>
> Can we move this and the next patch before patch 2, though? Otherwise, the tests adjusted in the next patch will be broken after patch 2 (when given those unsupported options). The move seems trivial, just wondering whether you know of anything that would prohibit this.
>
OK
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-12-23 14:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 13:07 [PATCH v4 00/19] iotests: support zstd Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 01/19] iotests.py: img_info_log(): rename imgopts argument Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 02/19] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd' Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 03/19] iotests: drop qemu_img_verbose() helper Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 04/19] iotests.py: rewrite default luks support in qemu_img Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 05/19] iotest 303: explicit compression type Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 06/19] iotest 065: " Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 07/19] iotests.py: filter out successful output of qemu-img create Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 08/19] iotests.py: filter compression type out Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 09/19] iotest 302: use img_info_log() helper Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 10/19] qcow2: simple case support for downgrading of qcow2 images with zstd Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 11/19] iotests/common.rc: introduce _qcow2_dump_header helper Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 12/19] iotests: massive use _qcow2_dump_header Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 13/19] iotest 39: " Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 14/19] iotests: bash tests: filter compression type Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 15/19] iotests 60: more accurate set dirty bit in qcow2 header Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 16/19] iotest 214: explicit compression type Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 17/19] iotests: declare lack of support for compresion_type in IMGOPTS Vladimir Sementsov-Ogievskiy
2021-12-03 13:07 ` [PATCH v4 18/19] iotests.py: implement unsupported_imgopts Vladimir Sementsov-Ogievskiy
2021-12-23 12:41 ` Hanna Reitz
2021-12-23 14:44 ` Vladimir Sementsov-Ogievskiy [this message]
2021-12-03 13:07 ` [PATCH v4 19/19] iotests: specify some unsupported_imgopts for python iotests Vladimir Sementsov-Ogievskiy
2021-12-23 12:44 ` Hanna Reitz
2021-12-23 14:44 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68e6209-2939-d0b2-aa48-77e45c7003bb@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).