From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45731)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <philmd@redhat.com>) id 1gNMeD-0005Yl-RQ
	for qemu-devel@nongnu.org; Thu, 15 Nov 2018 13:45:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <philmd@redhat.com>) id 1gNMe4-0003u1-UH
	for qemu-devel@nongnu.org; Thu, 15 Nov 2018 13:45:44 -0500
Received: from mail-wm1-f68.google.com ([209.85.128.68]:53009)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <philmd@redhat.com>) id 1gNMdw-0003gg-8Q
	for qemu-devel@nongnu.org; Thu, 15 Nov 2018 13:45:33 -0500
Received: by mail-wm1-f68.google.com with SMTP id r11-v6so19769676wmb.2
	for <qemu-devel@nongnu.org>; Thu, 15 Nov 2018 10:45:22 -0800 (PST)
References: <20181115143124.19234-1-pbonzini@redhat.com>
	<20181115143124.19234-10-pbonzini@redhat.com>
	<cc305bf4-fe14-89c0-79f3-a2051086e5f0@redhat.com>
	<eada6127-bfc8-6cc5-08ff-77a0e10c5bad@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>
Message-ID: <c6916689-fcd4-aff0-3eb9-0e44b63f9d04@redhat.com>
Date: Thu, 15 Nov 2018 19:45:19 +0100
MIME-Version: 1.0
In-Reply-To: <eada6127-bfc8-6cc5-08ff-77a0e10c5bad@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 09/10] vhost-user-test: small changes to
 init_hugepagefs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>, jasowang@redhat.com, mst@redhat.com

On 15/11/18 19:41, Paolo Bonzini wrote:
> On 15/11/2018 15:55, Philippe Mathieu-Daudé wrote:
>>>
>>>        if (access(path, R_OK | W_OK | X_OK)) {
>>>            g_test_message("access on path (%s): %s\n", path,
>>> strerror(errno));
>>> +        abort();
>>>            return NULL;
>>
>> Can we remove the 'return NULL's now?
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> I can remove them, but later on the aborts will become g_test_fail and
> the test will continue without hugepagefs.

OK, fine then!

Regards,

Phil.