qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cleber Rosa <crosa@redhat.com>,
	qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>,
	Wainer dos Santos Moschetta <wainersm@redhat.com>,
	Beraldo Leal <bleal@redhat.com>,
	Willian Rampazzo <wrampazz@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines
Date: Fri, 4 Sep 2020 18:59:24 +0200	[thread overview]
Message-ID: <c6940533-2bbe-8883-5b00-a2ae17df9864@redhat.com> (raw)
In-Reply-To: <20200904164258.240278-4-crosa@redhat.com>

On 9/4/20 6:42 PM, Cleber Rosa wrote:
> When waiting for a pipeline to run and finish, it's better to give
> early feedback, and then sleep and wait, than the other wait around.
> 
> Specially for the first iteration, it's frustrating to see nothing
> while the script is sleeping.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  scripts/ci/gitlab-pipeline-status | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
> index 2a36f74696..18609553be 100755
> --- a/scripts/ci/gitlab-pipeline-status
> +++ b/scripts/ci/gitlab-pipeline-status
> @@ -77,8 +77,8 @@ def wait_on_pipeline_success(timeout, interval,
>  
>          status = get_pipeline_status(project_id, commit_sha)
>          if status['status'] == 'running':
> -            time.sleep(interval)
>              print('running...')
> +            time.sleep(interval)
>              continue
>  
>          if status['status'] == 'success':
> 



  reply	other threads:[~2020-09-04 17:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 16:42 [PATCH 0/7] gitlab pipeline check/watch script improvements Cleber Rosa
2020-09-04 16:42 ` [PATCH 1/7] scripts/ci/gitlab-pipeline-status: make branch name configurable Cleber Rosa
2020-09-04 17:01   ` Philippe Mathieu-Daudé
2020-09-04 16:42 ` [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regarding timeout Cleber Rosa
2020-09-04 16:53   ` Philippe Mathieu-Daudé
2020-09-04 16:42 ` [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines Cleber Rosa
2020-09-04 16:59   ` Philippe Mathieu-Daudé [this message]
2020-09-04 16:42 ` [PATCH 4/7] scripts/ci/gitlab-pipeline-status: refactor parser creation Cleber Rosa
2020-09-04 16:42 ` [PATCH 5/7] scripts/ci/gitlab-pipeline-status: handle keyboard interrupts Cleber Rosa
2020-09-04 16:42 ` [PATCH 6/7] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions Cleber Rosa
2020-09-04 16:42 ` [PATCH 7/7] scripts/ci/gitlab-pipeline-status: wait for pipeline creation Cleber Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6940533-2bbe-8883-5b00-a2ae17df9864@redhat.com \
    --to=philmd@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).