* [PATCH] cxl: Get rid of unused cfmw_list
@ 2024-05-31 6:13 Li Zhijian via
2024-06-05 12:02 ` Jonathan Cameron via
0 siblings, 1 reply; 3+ messages in thread
From: Li Zhijian via @ 2024-05-31 6:13 UTC (permalink / raw)
To: qemu-devel; +Cc: fan.ni, jonathan.cameron, linux-cxl, Li Zhijian
There is no user for this member. All '-M cxl-fmw.N' options have
been parsed and saved to CXLState.fixed_windows.
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
hw/cxl/cxl-host.c | 1 -
include/hw/cxl/cxl.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
index c5f5fcfd64d0..926d3d3da705 100644
--- a/hw/cxl/cxl-host.c
+++ b/hw/cxl/cxl-host.c
@@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, const char *name,
for (it = cfmw_list; it; it = it->next) {
cxl_fixed_memory_window_config(state, it->value, errp);
}
- state->cfmw_list = cfmw_list;
}
void cxl_machine_init(Object *obj, CXLState *state)
diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h
index 75e47b686441..e3ecbef03872 100644
--- a/include/hw/cxl/cxl.h
+++ b/include/hw/cxl/cxl.h
@@ -43,7 +43,6 @@ typedef struct CXLState {
MemoryRegion host_mr;
unsigned int next_mr_idx;
GList *fixed_windows;
- CXLFixedMemoryWindowOptionsList *cfmw_list;
} CXLState;
struct CXLHost {
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cxl: Get rid of unused cfmw_list
2024-05-31 6:13 [PATCH] cxl: Get rid of unused cfmw_list Li Zhijian via
@ 2024-06-05 12:02 ` Jonathan Cameron via
2024-06-06 0:04 ` Zhijian Li (Fujitsu) via
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron via @ 2024-06-05 12:02 UTC (permalink / raw)
To: Li Zhijian; +Cc: qemu-devel, fan.ni, linux-cxl
On Fri, 31 May 2024 14:13:17 +0800
Li Zhijian <lizhijian@fujitsu.com> wrote:
> There is no user for this member. All '-M cxl-fmw.N' options have
> been parsed and saved to CXLState.fixed_windows.
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Hi Li,
Applied to my tree with slight change to patch title
to hw/cxl: Get rid of unused cfmw_list
I aim to send a group of more minor changes like this for upstream
in the next week or so.
Btw, to make it easy to spot QEMU patches in patchwork so that
the kernel maintainers can ignore them - when posting to linux-cxl@vger.kernel.org
[PATCH qemu]
marking for patches is helpful.
Thanks,
Jonathan
> ---
> hw/cxl/cxl-host.c | 1 -
> include/hw/cxl/cxl.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
> index c5f5fcfd64d0..926d3d3da705 100644
> --- a/hw/cxl/cxl-host.c
> +++ b/hw/cxl/cxl-host.c
> @@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, const char *name,
> for (it = cfmw_list; it; it = it->next) {
> cxl_fixed_memory_window_config(state, it->value, errp);
> }
> - state->cfmw_list = cfmw_list;
> }
>
> void cxl_machine_init(Object *obj, CXLState *state)
> diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h
> index 75e47b686441..e3ecbef03872 100644
> --- a/include/hw/cxl/cxl.h
> +++ b/include/hw/cxl/cxl.h
> @@ -43,7 +43,6 @@ typedef struct CXLState {
> MemoryRegion host_mr;
> unsigned int next_mr_idx;
> GList *fixed_windows;
> - CXLFixedMemoryWindowOptionsList *cfmw_list;
> } CXLState;
>
> struct CXLHost {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cxl: Get rid of unused cfmw_list
2024-06-05 12:02 ` Jonathan Cameron via
@ 2024-06-06 0:04 ` Zhijian Li (Fujitsu) via
0 siblings, 0 replies; 3+ messages in thread
From: Zhijian Li (Fujitsu) via @ 2024-06-06 0:04 UTC (permalink / raw)
To: Jonathan Cameron
Cc: qemu-devel@nongnu.org, fan.ni@samsung.com,
linux-cxl@vger.kernel.org
On 05/06/2024 20:02, Jonathan Cameron wrote:
> On Fri, 31 May 2024 14:13:17 +0800
> Li Zhijian <lizhijian@fujitsu.com> wrote:
>
>> There is no user for this member. All '-M cxl-fmw.N' options have
>> been parsed and saved to CXLState.fixed_windows.
>>
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>
> Hi Li,
>
> Applied to my tree with slight change to patch title
> to hw/cxl: Get rid of unused cfmw_list
>
> I aim to send a group of more minor changes like this for upstream
> in the next week or so.
Many thanks
>
> Btw, to make it easy to spot QEMU patches in patchwork so that
> the kernel maintainers can ignore them - when posting to linux-cxl@vger.kernel.org
> [PATCH qemu]
> marking for patches is helpful.
Thanks for your reminder.
Thanks
Zhijian
>
> Thanks,
>
> Jonathan
>
>> ---
>> hw/cxl/cxl-host.c | 1 -
>> include/hw/cxl/cxl.h | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
>> index c5f5fcfd64d0..926d3d3da705 100644
>> --- a/hw/cxl/cxl-host.c
>> +++ b/hw/cxl/cxl-host.c
>> @@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, const char *name,
>> for (it = cfmw_list; it; it = it->next) {
>> cxl_fixed_memory_window_config(state, it->value, errp);
>> }
>> - state->cfmw_list = cfmw_list;
>> }
>>
>> void cxl_machine_init(Object *obj, CXLState *state)
>> diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h
>> index 75e47b686441..e3ecbef03872 100644
>> --- a/include/hw/cxl/cxl.h
>> +++ b/include/hw/cxl/cxl.h
>> @@ -43,7 +43,6 @@ typedef struct CXLState {
>> MemoryRegion host_mr;
>> unsigned int next_mr_idx;
>> GList *fixed_windows;
>> - CXLFixedMemoryWindowOptionsList *cfmw_list;
>> } CXLState;
>>
>> struct CXLHost {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-06 0:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-31 6:13 [PATCH] cxl: Get rid of unused cfmw_list Li Zhijian via
2024-06-05 12:02 ` Jonathan Cameron via
2024-06-06 0:04 ` Zhijian Li (Fujitsu) via
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).