From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Subject: Re: [PATCH] checkpatch: Prefer DEFINE_TYPES() over type_init / type_register_static
Date: Wed, 24 May 2023 10:16:46 -0700 [thread overview]
Message-ID: <c6a2f3a9-1d4e-36de-9841-ad28927a3554@linaro.org> (raw)
In-Reply-To: <20230524145444.32820-1-philmd@linaro.org>
On 5/24/23 07:54, Philippe Mathieu-Daudé wrote:
> When multiple QOM types are registered in the same file, it
> is clearer and simpler to use the the DEFINE_TYPES() macro.
>
> Add a rule to checkpatch.pl to suggest using DEFINE_TYPES()
> instead of type_init() / type_register_static().
>
> Suggested-by: Daniel Henrique Barboza<dbarboza@ventanamicro.com>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> scripts/checkpatch.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-05-24 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 14:54 [PATCH] checkpatch: Prefer DEFINE_TYPES() over type_init / type_register_static Philippe Mathieu-Daudé
2023-05-24 17:16 ` Richard Henderson [this message]
2023-05-25 11:32 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6a2f3a9-1d4e-36de-9841-ad28927a3554@linaro.org \
--to=richard.henderson@linaro.org \
--cc=dbarboza@ventanamicro.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).