From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45BC8C77B73 for ; Wed, 24 May 2023 17:17:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1s6Y-0006Mi-56; Wed, 24 May 2023 13:16:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1s6W-0006Im-8f for qemu-devel@nongnu.org; Wed, 24 May 2023 13:16:52 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1s6U-00064h-La for qemu-devel@nongnu.org; Wed, 24 May 2023 13:16:52 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-52cb78647ecso416353a12.1 for ; Wed, 24 May 2023 10:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684948609; x=1687540609; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N1jCPZGzUZx2R5fAkIKTQSo4Ro/fUaj18sYgDSrz+4A=; b=RFPKkTSwV1Arzwea7frwbEDCGmGTihGcbLn0QcCIUYrCisXUmeYtfiUPJ5W7TlFyLG pE38MOjYny/gLvxfJ7a/CVBHVR233kvF9i92lkv2Fwc+/wNmSx3Zc5+LCyvsbsAmOlw0 SCsR9SbvEP8izpEntz5PpWfkcvEWWxqrT7wF5+Px5IvsugEohPM5Ww15LrDVH1jNUNRN hgUJfa+Lccw99tSr2L61uh4Dvk66kqoQEZC5084W7MQMHN2tGllGcduibxwZ8xlggDtL sLsxd4flBGLm9140A/796dyceT6bc7NYaK6kAz9elKRadgO908DipuBfXz5bc08iBbuP Cb3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684948609; x=1687540609; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N1jCPZGzUZx2R5fAkIKTQSo4Ro/fUaj18sYgDSrz+4A=; b=eeX3cQzYzHqwNC1E4Qv1+k8UQqnV+gDgIEoR2FJjHqka7CaKIdzakmGxNgwMisRAIX A7goM2YjxmQuDijIH1GJdzjgMm4eEtwXQceAKnYCQxhEk9/6t9Vdcj/1hTdJjZwhpGWK g4tEuVrUbzznN1sUscXa9gVL5h0EsgQAk/iBdX1NnhJ+dsQklEOb1S6fBbrkOyOqSxBu rg9xwajYvkWs1TFz+1p9zz3p1+z41mbrHXm3VJc1B9WwBm4IosN3acIYg09NxK0HB9J9 SvNPZkI7kqlO3X66uxLIljWTcFD+pYB+AtRBhGrRXHGmcnvzCg/J0zbLAlWEwnqjQQiP ZDBQ== X-Gm-Message-State: AC+VfDxV9TT+2P9zycGnvYGwXCj/vw0NjvRIEiebxWhH/fu1z8ZV6dMj FtLC2zzewfEPIPIlHNhqS8+jXA== X-Google-Smtp-Source: ACHHUZ44d81YVv2kP6EKOI8IXZAXZpUxamijVlBR4VXHU3MBeHHHklUi6vJwHYtywDIxTJTP87Lvsw== X-Received: by 2002:a17:903:41cf:b0:1ad:bb89:16f6 with SMTP id u15-20020a17090341cf00b001adbb8916f6mr21771387ple.50.1684948609276; Wed, 24 May 2023 10:16:49 -0700 (PDT) Received: from ?IPV6:2602:ae:1598:4c01:6b03:9af2:33c1:3d6b? ([2602:ae:1598:4c01:6b03:9af2:33c1:3d6b]) by smtp.gmail.com with ESMTPSA id l12-20020a170902d34c00b0019e5fc21663sm8967437plk.218.2023.05.24.10.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 10:16:48 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 10:16:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] checkpatch: Prefer DEFINE_TYPES() over type_init / type_register_static Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza References: <20230524145444.32820-1-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230524145444.32820-1-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.107, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/24/23 07:54, Philippe Mathieu-Daudé wrote: > When multiple QOM types are registered in the same file, it > is clearer and simpler to use the the DEFINE_TYPES() macro. > > Add a rule to checkpatch.pl to suggest using DEFINE_TYPES() > instead of type_init() / type_register_static(). > > Suggested-by: Daniel Henrique Barboza > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/checkpatch.pl | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Richard Henderson r~