From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
dave@treblig.org, qemu-trivial@nongnu.org, mjt@tls.msk.ru,
laurent@vivier.eu
Cc: jak@jak-linux.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu-options.hx: Replace deprecated -M example
Date: Tue, 2 Dec 2025 08:47:37 +0100 [thread overview]
Message-ID: <c6b78af8-7da6-4ac0-9e74-dc67e2b4d4d7@redhat.com> (raw)
In-Reply-To: <95dd7914-8e58-42e7-9988-cd7822f17bca@redhat.com>
On 12/2/25 08:14, Thomas Huth wrote:
> On 02/12/2025 01.57, dave@treblig.org wrote:
>> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>>
>> The -M option was deprecated by -machine in 2011 by 80f52a669
>> and isn't actually documented in the manpage, but is still used in
>> one of the examples. Replace it by -machine.
>> -M still gets used all over the place in other docs, and I'm
>> not sure I realised it was deprecated until Julian pointed out it
>> wasn't actually documented.
>
> -M is not mentioned in docs/about/deprecated.rst, so no, it's not
> officially deprecated. And I think it's a nice short hand feature for an
> option that is used very often, so I also don't think that we should
> ever remove it. Thus I think it would be better to simply add it back to
> qemu-options.hx instead.
Yes, its status as a synonym of -machine started only in 2015, in a
commit that didn't even mention that effect:
commit 364c3e6b8dd7912e01d19122d791b8c8f6df4f6c
Author: Marcel Apfelbaum <marcel@redhat.com>
Date: Wed Jan 7 14:11:38 2015 +0200
vl.c: fix regression when reading machine type from config file
After 'Machine as QOM' series the machine type input triggers
the creation of the machine class.
If the machine type is set in the configuration file, the machine
class is not updated accordingly and remains the default.
Fixed that by querying the machine options after the configuration
file is loaded.
Cc: qemu-stable@nongnu.org
Reported-by: William Dauchy <william@gandi.net>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(I wonder who's the guy that committed it). But it was a good idea, and
there's no need to change this.
Paolo
next prev parent reply other threads:[~2025-12-02 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 0:57 [PATCH] qemu-options.hx: Replace deprecated -M example dave
2025-12-02 7:14 ` Thomas Huth
2025-12-02 7:47 ` Paolo Bonzini [this message]
2025-12-02 12:30 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6b78af8-7da6-4ac0-9e74-dc67e2b4d4d7@redhat.com \
--to=pbonzini@redhat.com \
--cc=dave@treblig.org \
--cc=jak@jak-linux.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).