qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Mauro Matteo Cascella" <mcascell@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Bandan Das" <bsd@redhat.com>,
	"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Jon Maloy" <jmaloy@redhat.com>, "Siqi Chen" <coc.cyqh@gmail.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>
Subject: Re: [PATCH v8 5/8] memory: Allow disabling re-entrancy checking per-MR
Date: Tue, 25 Apr 2023 09:41:02 +0200	[thread overview]
Message-ID: <c6c5f756-c226-e091-c30c-97895a0234ed@redhat.com> (raw)
In-Reply-To: <20230421142736.2817601-6-alxndr@bu.edu>

On 21/04/2023 16.27, Alexander Bulekov wrote:
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
> ---
>   include/exec/memory.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 6c0a5e68d3..4e9531bd8a 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -793,6 +793,9 @@ struct MemoryRegion {
>       unsigned ioeventfd_nb;
>       MemoryRegionIoeventfd *ioeventfds;
>       RamDiscardManager *rdm; /* Only for RAM */
> +
> +    /* For devices designed to perform re-entrant IO into their own IO MRs */
> +    bool disable_reentrancy_guard;
>   };
>   
>   struct IOMMUMemoryRegion {

Oh, wait, that check for "!mr->disable_reentrancy_guard" has been squashed 
into the first patch now ... that's bad, I think you should squash this into 
the first patch now, too!

  Thomas



  reply	other threads:[~2023-04-25  7:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 14:27 [PATCH v8 0/8] memory: prevent dma-reentracy issues Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 1/8] " Alexander Bulekov
2023-04-25  7:32   ` Thomas Huth
2023-04-21 14:27 ` [PATCH v8 2/8] async: Add an optional reentrancy guard to the BH API Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 3/8] checkpatch: add qemu_bh_new/aio_bh_new checks Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 4/8] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 5/8] memory: Allow disabling re-entrancy checking per-MR Alexander Bulekov
2023-04-25  7:41   ` Thomas Huth [this message]
2023-04-26 15:59     ` Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 6/8] lsi53c895a: disable reentrancy detection for script RAM Alexander Bulekov
2023-04-21 14:27 ` [PATCH v8 7/8] bcm2835_property: disable reentrancy detection for iomem Alexander Bulekov
2023-04-25  7:43   ` Thomas Huth
2023-04-21 14:27 ` [PATCH v8 8/8] memory: abort on re-entrancy in debug builds Alexander Bulekov
2023-04-25  7:44   ` Thomas Huth
2023-04-25  9:46 ` [PATCH v8 0/8] memory: prevent dma-reentracy issues Thomas Huth
2023-04-26 16:03   ` Alexander Bulekov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6c5f756-c226-e091-c30c-97895a0234ed@redhat.com \
    --to=thuth@redhat.com \
    --cc=alxndr@bu.edu \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=bsd@redhat.com \
    --cc=coc.cyqh@gmail.com \
    --cc=darren.kenny@oracle.com \
    --cc=david@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=jasowang@redhat.com \
    --cc=jmaloy@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mcascell@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).