From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Andrew Randrianasulu <randrianasulu@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: ALSA support in qemu-user?
Date: Mon, 14 Oct 2024 11:21:46 +0200 [thread overview]
Message-ID: <c6c9ddd2-49bb-4c15-bc58-e72063be3a21@redhat.com> (raw)
In-Reply-To: <CAFEAcA_-ncUdRTO+CpFCf44OY6toTBWw8-5y5zbnr3PSfn2sGA@mail.gmail.com>
On 14/10/2024 11.06, Peter Maydell wrote:
> On Mon, 14 Oct 2024 at 02:13, Andrew Randrianasulu
> <randrianasulu@gmail.com> wrote:
>>
>> some 8 years ago this patch was sent to qemu-devel:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg05333.html
>> "[Qemu-devel] [PATCH 7/7] Add ALSA ioctls"
>>
>> I wonder why it was rejected, may be as part of series?
>
> Hard to say from this distance, but looking at the patch
> I think it probably was just that it was on the end of
> a series that did a bunch of other things and the earlier
> patches in the series had issues.
Yes, looks like there were review comments on the series that were not
addressed:
https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg05557.html
https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg05364.html
But mainly one of the problems were that the patches haven't been send in a
proper threaded way, so it was hard to follow the series:
https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg05546.html
Anyway, looking at the other patches, it seems most of them were not related
to ALSA, so you might be fine in just picking that patch, get it to work
with the latest version of QEMU again and send just that single updated
patch to this mailing list again. YMMV of course.
Thomas
next prev parent reply other threads:[~2024-10-14 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 1:18 ALSA support in qemu-user? Andrew Randrianasulu
2024-10-14 9:06 ` Peter Maydell
2024-10-14 9:21 ` Thomas Huth [this message]
2024-10-14 14:26 ` Andrew Randrianasulu
2024-10-15 14:06 ` Andrew Randrianasulu
2024-10-15 21:50 ` Andrew Randrianasulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c9ddd2-49bb-4c15-bc58-e72063be3a21@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=randrianasulu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).