From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Ani Sinha <anisinha@redhat.com>
Subject: Re: [PATCH 3/6] tests/qtest/bios-tables-test: Free tables at dump_aml_files
Date: Mon, 9 Dec 2024 22:04:42 +0100 [thread overview]
Message-ID: <c6d03941-6100-46a4-9258-a465ca0557a2@linaro.org> (raw)
In-Reply-To: <20241209204427.17763-4-farosas@suse.de>
On 9/12/24 21:44, Fabiano Rosas wrote:
> The dump_aml_files() function calls load_expected_aml() to allocate
> the tables but never frees it. Add the missing call to
> free_test_data().
>
This is also Coverity CID 1549449 (RESOURCE_LEAK)
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/qtest/bios-tables-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 16d0ffbdf6..1cf4e3f7ef 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -292,6 +292,7 @@ static void dump_aml_files(test_data *data, bool rebuild)
>
> g_free(aml_file);
> }
> + free_test_data(&exp_data);
> }
>
> static bool create_tmp_asl(AcpiSdtTable *sdt)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-12-09 21:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 20:44 [PATCH 0/6] qtest: Fix some memory issues Fabiano Rosas
2024-12-09 20:44 ` [PATCH 1/6] tests/qtest/migration: Do proper cleanup in the dirty_limit test Fabiano Rosas
2024-12-09 21:11 ` Peter Xu
2024-12-09 20:44 ` [PATCH 2/6] tests/qtest/migration: Initialize buffer in probe_o_direct_support Fabiano Rosas
2024-12-09 21:02 ` Philippe Mathieu-Daudé
2024-12-09 21:14 ` Peter Xu
2024-12-09 20:44 ` [PATCH 3/6] tests/qtest/bios-tables-test: Free tables at dump_aml_files Fabiano Rosas
2024-12-09 21:04 ` Philippe Mathieu-Daudé [this message]
2024-12-09 20:44 ` [PATCH 4/6] tests/qtest/virtio-iommu-test: Don't pass uninitialized data into qtest_memwrite Fabiano Rosas
2024-12-09 21:06 ` Philippe Mathieu-Daudé
2024-12-09 20:44 ` [PATCH 5/6] tests/qtest/qos-test: Plug a couple of leaks Fabiano Rosas
2024-12-09 20:44 ` [PATCH 6/6] tests/qtest/test-x86-cpuid-compat: Free allocated memory Fabiano Rosas
2024-12-17 18:13 ` [PATCH 0/6] qtest: Fix some memory issues Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6d03941-6100-46a4-9258-a465ca0557a2@linaro.org \
--to=philmd@linaro.org \
--cc=anisinha@redhat.com \
--cc=farosas@suse.de \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).