* [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1`
@ 2025-07-17 20:57 Roman Kiryanov
2025-07-18 0:38 ` Richard Henderson
2025-07-18 6:06 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Roman Kiryanov @ 2025-07-17 20:57 UTC (permalink / raw)
To: qemu-devel; +Cc: eric.auger, mjt, whollins, jansene, jpcottin, Roman Kiryanov
this function is declared in smmu-common.h without
`inline`. It is also used outside of this file
which causes linking errors because the non-inline
version is not generated.
Signed-off-by: Will Hollins <whollins@google.com>
Signed-off-by: Roman Kiryanov <rkir@google.com>
---
hw/arm/smmu-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
index f39b99e526..0dcaf2f589 100644
--- a/hw/arm/smmu-common.c
+++ b/hw/arm/smmu-common.c
@@ -319,7 +319,7 @@ void smmu_iotlb_inv_vmid(SMMUState *s, int vmid)
g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid, &vmid);
}
-inline void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
+void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
{
trace_smmu_iotlb_inv_vmid_s1(vmid);
g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid_s1, &vmid);
--
2.50.0.727.gbf7dc18ff4-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1`
2025-07-17 20:57 [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1` Roman Kiryanov
@ 2025-07-18 0:38 ` Richard Henderson
2025-07-18 6:06 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2025-07-18 0:38 UTC (permalink / raw)
To: Roman Kiryanov, qemu-devel; +Cc: eric.auger, mjt, whollins, jansene, jpcottin
On 7/17/25 13:57, Roman Kiryanov wrote:
> this function is declared in smmu-common.h without
> `inline`. It is also used outside of this file
> which causes linking errors because the non-inline
> version is not generated.
>
> Signed-off-by: Will Hollins <whollins@google.com>
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> hw/arm/smmu-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
> index f39b99e526..0dcaf2f589 100644
> --- a/hw/arm/smmu-common.c
> +++ b/hw/arm/smmu-common.c
> @@ -319,7 +319,7 @@ void smmu_iotlb_inv_vmid(SMMUState *s, int vmid)
> g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid, &vmid);
> }
>
> -inline void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
> +void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
> {
> trace_smmu_iotlb_inv_vmid_s1(vmid);
> g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid_s1, &vmid);
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1`
2025-07-17 20:57 [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1` Roman Kiryanov
2025-07-18 0:38 ` Richard Henderson
@ 2025-07-18 6:06 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-07-18 6:06 UTC (permalink / raw)
To: Roman Kiryanov, qemu-devel; +Cc: eric.auger, mjt, whollins, jansene, jpcottin
On 17/7/25 22:57, Roman Kiryanov wrote:
> this function is declared in smmu-common.h without
> `inline`. It is also used outside of this file
> which causes linking errors because the non-inline
> version is not generated.
>
> Signed-off-by: Will Hollins <whollins@google.com>
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> hw/arm/smmu-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
> index f39b99e526..0dcaf2f589 100644
> --- a/hw/arm/smmu-common.c
> +++ b/hw/arm/smmu-common.c
> @@ -319,7 +319,7 @@ void smmu_iotlb_inv_vmid(SMMUState *s, int vmid)
> g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid, &vmid);
> }
>
> -inline void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
> +void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
> {
> trace_smmu_iotlb_inv_vmid_s1(vmid);
> g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid_s1, &vmid);
Already posted (but missed):
https://lore.kernel.org/qemu-devel/20250214072029.515379-1-jansef.jian@hj-micro.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-18 6:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-17 20:57 [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1` Roman Kiryanov
2025-07-18 0:38 ` Richard Henderson
2025-07-18 6:06 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).