From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81C29CF9C6B for ; Tue, 24 Sep 2024 16:24:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1st8Ji-0002Op-HK; Tue, 24 Sep 2024 12:23:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st8Je-0002Ns-Gp; Tue, 24 Sep 2024 12:23:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st8Jc-0002c2-Ta; Tue, 24 Sep 2024 12:23:06 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48OCvF9I023256; Tue, 24 Sep 2024 16:23:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; s=pp1; bh= y9H9c0M+gFRVLPnVU8xoh9amEoQK12cGzvsnIEFD554=; b=VYG48MJdFIGp58F0 2eLyRAMZuyveL2DWpmJOZE1LGyVr4MmaaD1A22DCGlCiCkVQdZ19p8uWu+sTVpT1 u5iegoEuUMmEVox63T+8Ip6tjH2/lbFImUY6X9CmTWYR0k44W1bIaQhmGYW0t8ZT fTmdJGkPlDesc9bWgrKxHsTFVtoQnBUGTf2aoQgihenLzbybnXUWYzECyGHemNNT 2nBcNUSwFNwUzDxU7QITqrIcUMcclNGE2VbVTE57CvnKab6rsDWb/XRO5XDuoyX2 eVKwNajf5a6c9z+RVM3PFfwBFn95B4rWKZzjpycSlmnYz71Klz/3HFep+FFDiX8/ jmIguw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41snt1aw50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Sep 2024 16:23:00 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 48OGMxbj011281; Tue, 24 Sep 2024 16:22:59 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41snt1aw4w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Sep 2024 16:22:59 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48OGIdYq000682; Tue, 24 Sep 2024 16:22:58 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 41t8fun4xa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Sep 2024 16:22:58 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48OGMtdV49283566 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Sep 2024 16:22:55 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55DA62004B; Tue, 24 Sep 2024 16:22:55 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4B9F520043; Tue, 24 Sep 2024 16:22:54 +0000 (GMT) Received: from li-978a334c-2cba-11b2-a85c-a0743a31b510.ibm.com (unknown [9.171.59.21]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 24 Sep 2024 16:22:54 +0000 (GMT) Message-ID: Subject: Re: [PATCH v1 10/14] s390x/pv: check initial, not maximum RAM size From: Nina Schoetterl-Glausch To: David Hildenbrand , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Paolo Bonzini , Thomas Huth , Halil Pasic , Christian Borntraeger , Eric Farman , Richard Henderson , Ilya Leoshkevich , Janosch Frank , "Michael S. Tsirkin" , Cornelia Huck Date: Tue, 24 Sep 2024 18:22:53 +0200 In-Reply-To: <20240910175809.2135596-11-david@redhat.com> References: <20240910175809.2135596-1-david@redhat.com> <20240910175809.2135596-11-david@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3 (3.52.3-1.fc40) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: P9QclBoS5wm_v0iv6TdmKvXHq2CnGNos X-Proofpoint-GUID: 4oJl_afdMsQPxaVRoGs0Tv77iD3JbTsy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-24_02,2024-09-24_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=831 priorityscore=1501 suspectscore=0 mlxscore=0 clxscore=1015 impostorscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409240113 Received-SPF: pass client-ip=148.163.158.5; envelope-from=nsg@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, 2024-09-10 at 19:58 +0200, David Hildenbrand wrote: > We actually want to check the available RAM, not the maximum RAM size. >=20 > Signed-off-by: David Hildenbrand Reviewed-by: Nina Schoetterl-Glausch Nit below. > --- > target/s390x/kvm/pv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/target/s390x/kvm/pv.c b/target/s390x/kvm/pv.c > index dde836d21a..424cce75ca 100644 > --- a/target/s390x/kvm/pv.c > +++ b/target/s390x/kvm/pv.c > @@ -133,7 +133,7 @@ bool s390_pv_vm_try_disable_async(S390CcwMachineState= *ms) > * If the feature is not present or if the VM is not larger than 2 G= iB, > * KVM_PV_ASYNC_CLEANUP_PREPARE fill fail; no point in attempting it= . > */ > - if ((MACHINE(ms)->maxram_size <=3D 2 * GiB) || > + if ((MACHINE(ms)->ram_size <=3D 2 * GiB) || > !kvm_check_extension(kvm_state, KVM_CAP_S390_PROTECTED_ASYNC_DIS= ABLE)) { > return false; > } If I understood the kernel code right, the decision is made wrt the size of the gmap address space, which is the same as the limit set for the VM. So using s390_get_memory_limit would be semantically cleaner.