From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Daniel Henrique Barboza <danielhb413@gmail.com>
Subject: Re: [PATCH v2 for-8.2] ppc/amigaone: Allow running AmigaOS without firmware image
Date: Tue, 28 Nov 2023 10:16:51 +0100 [thread overview]
Message-ID: <c6dbd03f-a060-46b1-bf25-c9a6387f6347@linaro.org> (raw)
In-Reply-To: <595c26d6-ef8f-443e-8192-3e73ee6b7d75@kaod.org>
On 28/11/23 08:07, Cédric Le Goater wrote:
> On 11/28/23 02:47, Nicholas Piggin wrote:
>> On Tue Nov 28, 2023 at 2:37 AM AEST, Cédric Le Goater wrote:
>>>
>>>> I'm not sure, I don't think it's necessary if your minimal patch works.
>>>>
>>>> I'll do a PR for 8.2 for SLOF and Skiboot updates, so happy to include
>>>> this as well.
>> I think this amigaone patch could still be merged since it's only
>> touching a new machine and it's fixing an issue of missing firmware.
>
> ARM does something similar with roms. See hw/arm/boot.c file.
>
> It will need a "Fixes" tag.
Fixes: d9656f860a ("hw/ppc: Add emulation of AmigaOne XE board")
next prev parent reply other threads:[~2023-11-28 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 16:34 [PATCH v2 for-8.2] ppc/amigaone: Allow running AmigaOS without firmware image BALATON Zoltan
2023-11-27 7:13 ` Nicholas Piggin
2023-11-27 11:43 ` BALATON Zoltan
2023-11-27 12:50 ` Nicholas Piggin
2023-11-27 13:49 ` BALATON Zoltan
2023-11-27 16:37 ` Cédric Le Goater
2023-11-28 1:47 ` Nicholas Piggin
2023-11-28 7:07 ` Cédric Le Goater
2023-11-28 9:16 ` Philippe Mathieu-Daudé [this message]
2023-11-28 12:40 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6dbd03f-a060-46b1-bf25-c9a6387f6347@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).