* [PATCH] test/functional: Fix Aspeed buildroot tests
@ 2024-11-05 13:23 Cédric Le Goater
2024-11-05 13:30 ` Thomas Huth
2024-11-05 14:38 ` Peter Maydell
0 siblings, 2 replies; 5+ messages in thread
From: Cédric Le Goater @ 2024-11-05 13:23 UTC (permalink / raw)
To: qemu-devel, qemu-arm; +Cc: Peter Maydell, Cédric Le Goater, Thomas Huth
Since commit 786bc2255256, cached asset files are read-only. Adjust
the QEMU command line for buildroot tests to reflect the new
constraint on the flash drive.
Fixes: f04cb2d00d5c ("tests/functional: Convert most Aspeed machine tests")
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
tests/functional/test_arm_aspeed.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/functional/test_arm_aspeed.py b/tests/functional/test_arm_aspeed.py
index 9761fc06a454..19853161b267 100644
--- a/tests/functional/test_arm_aspeed.py
+++ b/tests/functional/test_arm_aspeed.py
@@ -125,7 +125,7 @@ def test_arm_ast2500_romulus_openbmc_v2_9_0(self):
def do_test_arm_aspeed_buildroot_start(self, image, cpu_id, pattern='Aspeed EVB'):
self.require_netdev('user')
self.vm.set_console()
- self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw',
+ self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw,read-only=true',
'-net', 'nic', '-net', 'user')
self.vm.launch()
--
2.47.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] test/functional: Fix Aspeed buildroot tests
2024-11-05 13:23 [PATCH] test/functional: Fix Aspeed buildroot tests Cédric Le Goater
@ 2024-11-05 13:30 ` Thomas Huth
2024-11-05 14:38 ` Peter Maydell
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2024-11-05 13:30 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel, qemu-arm; +Cc: Peter Maydell
On 05/11/2024 14.23, Cédric Le Goater wrote:
> Since commit 786bc2255256, cached asset files are read-only. Adjust
> the QEMU command line for buildroot tests to reflect the new
> constraint on the flash drive.
>
> Fixes: f04cb2d00d5c ("tests/functional: Convert most Aspeed machine tests")
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> tests/functional/test_arm_aspeed.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/functional/test_arm_aspeed.py b/tests/functional/test_arm_aspeed.py
> index 9761fc06a454..19853161b267 100644
> --- a/tests/functional/test_arm_aspeed.py
> +++ b/tests/functional/test_arm_aspeed.py
> @@ -125,7 +125,7 @@ def test_arm_ast2500_romulus_openbmc_v2_9_0(self):
> def do_test_arm_aspeed_buildroot_start(self, image, cpu_id, pattern='Aspeed EVB'):
> self.require_netdev('user')
> self.vm.set_console()
> - self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw',
> + self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw,read-only=true',
> '-net', 'nic', '-net', 'user')
> self.vm.launch()
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] test/functional: Fix Aspeed buildroot tests
2024-11-05 13:23 [PATCH] test/functional: Fix Aspeed buildroot tests Cédric Le Goater
2024-11-05 13:30 ` Thomas Huth
@ 2024-11-05 14:38 ` Peter Maydell
2024-11-05 14:42 ` Thomas Huth
2024-11-05 15:08 ` Cédric Le Goater
1 sibling, 2 replies; 5+ messages in thread
From: Peter Maydell @ 2024-11-05 14:38 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-devel, qemu-arm, Thomas Huth
On Tue, 5 Nov 2024 at 13:23, Cédric Le Goater <clg@redhat.com> wrote:
>
> Since commit 786bc2255256, cached asset files are read-only. Adjust
> the QEMU command line for buildroot tests to reflect the new
> constraint on the flash drive.
>
> Fixes: f04cb2d00d5c ("tests/functional: Convert most Aspeed machine tests")
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> tests/functional/test_arm_aspeed.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/functional/test_arm_aspeed.py b/tests/functional/test_arm_aspeed.py
> index 9761fc06a454..19853161b267 100644
> --- a/tests/functional/test_arm_aspeed.py
> +++ b/tests/functional/test_arm_aspeed.py
> @@ -125,7 +125,7 @@ def test_arm_ast2500_romulus_openbmc_v2_9_0(self):
> def do_test_arm_aspeed_buildroot_start(self, image, cpu_id, pattern='Aspeed EVB'):
> self.require_netdev('user')
> self.vm.set_console()
> - self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw',
> + self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw,read-only=true',
> '-net', 'nic', '-net', 'user')
There are a couple of other places in this file where we add
a '-drive' option pointing to a file -- do they also need
read-only=true adding ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] test/functional: Fix Aspeed buildroot tests
2024-11-05 14:38 ` Peter Maydell
@ 2024-11-05 14:42 ` Thomas Huth
2024-11-05 15:08 ` Cédric Le Goater
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2024-11-05 14:42 UTC (permalink / raw)
To: Peter Maydell, Cédric Le Goater; +Cc: qemu-devel, qemu-arm
On 05/11/2024 15.38, Peter Maydell wrote:
> On Tue, 5 Nov 2024 at 13:23, Cédric Le Goater <clg@redhat.com> wrote:
>>
>> Since commit 786bc2255256, cached asset files are read-only. Adjust
>> the QEMU command line for buildroot tests to reflect the new
>> constraint on the flash drive.
>>
>> Fixes: f04cb2d00d5c ("tests/functional: Convert most Aspeed machine tests")
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>> tests/functional/test_arm_aspeed.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/functional/test_arm_aspeed.py b/tests/functional/test_arm_aspeed.py
>> index 9761fc06a454..19853161b267 100644
>> --- a/tests/functional/test_arm_aspeed.py
>> +++ b/tests/functional/test_arm_aspeed.py
>> @@ -125,7 +125,7 @@ def test_arm_ast2500_romulus_openbmc_v2_9_0(self):
>> def do_test_arm_aspeed_buildroot_start(self, image, cpu_id, pattern='Aspeed EVB'):
>> self.require_netdev('user')
>> self.vm.set_console()
>> - self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw',
>> + self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw,read-only=true',
>> '-net', 'nic', '-net', 'user')
>
> There are a couple of other places in this file where we add
> a '-drive' option pointing to a file -- do they also need
> read-only=true adding ?
I'm seeing problems with the ppc64_hv and the ppc_40p tests, but fortunately
they are hidden behind some @skipUnless decorators. I'm working on a patch...
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] test/functional: Fix Aspeed buildroot tests
2024-11-05 14:38 ` Peter Maydell
2024-11-05 14:42 ` Thomas Huth
@ 2024-11-05 15:08 ` Cédric Le Goater
1 sibling, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2024-11-05 15:08 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm, Thomas Huth
On 11/5/24 15:38, Peter Maydell wrote:
> On Tue, 5 Nov 2024 at 13:23, Cédric Le Goater <clg@redhat.com> wrote:
>>
>> Since commit 786bc2255256, cached asset files are read-only. Adjust
>> the QEMU command line for buildroot tests to reflect the new
>> constraint on the flash drive.
>>
>> Fixes: f04cb2d00d5c ("tests/functional: Convert most Aspeed machine tests")
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>> tests/functional/test_arm_aspeed.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/functional/test_arm_aspeed.py b/tests/functional/test_arm_aspeed.py
>> index 9761fc06a454..19853161b267 100644
>> --- a/tests/functional/test_arm_aspeed.py
>> +++ b/tests/functional/test_arm_aspeed.py
>> @@ -125,7 +125,7 @@ def test_arm_ast2500_romulus_openbmc_v2_9_0(self):
>> def do_test_arm_aspeed_buildroot_start(self, image, cpu_id, pattern='Aspeed EVB'):
>> self.require_netdev('user')
>> self.vm.set_console()
>> - self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw',
>> + self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw,read-only=true',
>> '-net', 'nic', '-net', 'user')
>
> There are a couple of other places in this file where we add
> a '-drive' option pointing to a file -- do they also need
> read-only=true adding ?
The other tests use an OpenBMC drive image which is modified at boot
and so they have a '-snapshot' option on the command line.
The buildroot drive image shouldn't be modified although 'rw' access
is required. I am not sure why.
Thanks,
C.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-11-05 15:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-05 13:23 [PATCH] test/functional: Fix Aspeed buildroot tests Cédric Le Goater
2024-11-05 13:30 ` Thomas Huth
2024-11-05 14:38 ` Peter Maydell
2024-11-05 14:42 ` Thomas Huth
2024-11-05 15:08 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).