From: John Snow <jsnow@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-disk: add missing break
Date: Mon, 6 Jun 2016 15:22:32 -0400 [thread overview]
Message-ID: <c6eff8b3-ce10-c1fa-4fd5-7f3497954fee@redhat.com> (raw)
In-Reply-To: <1465209273-31237-1-git-send-email-pbonzini@redhat.com>
On 06/06/2016 06:34 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/scsi/scsi-disk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index d5e8c8b..4b596d2 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2740,6 +2740,7 @@ static int32_t scsi_block_dma_command(SCSIRequest *req, uint8_t *buf)
> /* 10-byte CDB. */
> r->cdb1 = req->cmd.buf[1];
> r->group_number = req->cmd.buf[6];
> + break;
> case 4:
> /* 12-byte CDB. */
> r->cdb1 = req->cmd.buf[1];
>
Not that you need *my* review to pull something into your *own* branch, but:
Reviewed-by: John Snow <jsnow@redhat.com>
prev parent reply other threads:[~2016-06-06 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 10:34 [Qemu-devel] [PATCH] scsi-disk: add missing break Paolo Bonzini
2016-06-06 19:22 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6eff8b3-ce10-c1fa-4fd5-7f3497954fee@redhat.com \
--to=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).