From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA06d-0000Z6-WB for qemu-devel@nongnu.org; Mon, 06 Jun 2016 15:22:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA06c-0003tj-45 for qemu-devel@nongnu.org; Mon, 06 Jun 2016 15:22:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA06b-0003tX-UR for qemu-devel@nongnu.org; Mon, 06 Jun 2016 15:22:34 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32DCA8F517 for ; Mon, 6 Jun 2016 19:22:33 +0000 (UTC) References: <1465209273-31237-1-git-send-email-pbonzini@redhat.com> From: John Snow Message-ID: Date: Mon, 6 Jun 2016 15:22:32 -0400 MIME-Version: 1.0 In-Reply-To: <1465209273-31237-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi-disk: add missing break List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 06/06/2016 06:34 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/scsi/scsi-disk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index d5e8c8b..4b596d2 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -2740,6 +2740,7 @@ static int32_t scsi_block_dma_command(SCSIRequest *req, uint8_t *buf) > /* 10-byte CDB. */ > r->cdb1 = req->cmd.buf[1]; > r->group_number = req->cmd.buf[6]; > + break; > case 4: > /* 12-byte CDB. */ > r->cdb1 = req->cmd.buf[1]; > Not that you need *my* review to pull something into your *own* branch, but: Reviewed-by: John Snow