* [Qemu-devel] [PATCH] scsi-disk: add missing break
@ 2016-06-06 10:34 Paolo Bonzini
2016-06-06 19:22 ` John Snow
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-06-06 10:34 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/scsi-disk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index d5e8c8b..4b596d2 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2740,6 +2740,7 @@ static int32_t scsi_block_dma_command(SCSIRequest *req, uint8_t *buf)
/* 10-byte CDB. */
r->cdb1 = req->cmd.buf[1];
r->group_number = req->cmd.buf[6];
+ break;
case 4:
/* 12-byte CDB. */
r->cdb1 = req->cmd.buf[1];
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] scsi-disk: add missing break
2016-06-06 10:34 [Qemu-devel] [PATCH] scsi-disk: add missing break Paolo Bonzini
@ 2016-06-06 19:22 ` John Snow
0 siblings, 0 replies; 2+ messages in thread
From: John Snow @ 2016-06-06 19:22 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 06/06/2016 06:34 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/scsi/scsi-disk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index d5e8c8b..4b596d2 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2740,6 +2740,7 @@ static int32_t scsi_block_dma_command(SCSIRequest *req, uint8_t *buf)
> /* 10-byte CDB. */
> r->cdb1 = req->cmd.buf[1];
> r->group_number = req->cmd.buf[6];
> + break;
> case 4:
> /* 12-byte CDB. */
> r->cdb1 = req->cmd.buf[1];
>
Not that you need *my* review to pull something into your *own* branch, but:
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-06 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-06 10:34 [Qemu-devel] [PATCH] scsi-disk: add missing break Paolo Bonzini
2016-06-06 19:22 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).