qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org,
	"Daniel P . Berrange" <berrange@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>
Subject: Re: [PATCH 3/3] capstone: Remove the capstone submodule
Date: Fri, 3 Jun 2022 17:05:45 +0200	[thread overview]
Message-ID: <c7274cba-130c-b2fb-f6fa-453787ad8bad@redhat.com> (raw)
In-Reply-To: <81c001a9-7709-66e5-fe71-370ebf3cb39b@linaro.org>

On 03/06/2022 15.48, Richard Henderson wrote:
> On 6/2/22 22:21, Thomas Huth wrote:
>> So is capstone disassembly better now with Ubuntu 20.04 or should we still 
>> revert the submodule removal?
> 
> It's better, yes.  At least it's giving me disassembly of the system registers.
> 
>> Also, if libvixl is so bad, why do we still have that in the repo?
> 
> Well, we just removed 3 other old disassemblers -- I think libvixl can be next.

I thought there was a reason for keeping vixl around ... but seems my memory 
is wrong here. After searching a little bit, I only found this here:

  https://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg03416.html

So seems like there was already the idea of removing vixl four years ago... 
I'll send a patch to remove it.

  Thomas



      reply	other threads:[~2022-06-03 15:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 14:58 [RFC PATCH 0/3] Allow Capstone 3.0.5 again and remove the submodule Thomas Huth
2022-05-16 14:58 ` [PATCH 1/3] tests/vm: Add capstone to the NetBSD and OpenBSD VMs Thomas Huth
2022-05-17  5:37   ` Richard Henderson
2022-05-16 14:58 ` [PATCH 2/3] capstone: Allow version 3.0.5 again Thomas Huth
2022-05-16 15:46   ` Peter Maydell
2022-05-16 16:46     ` Richard Henderson
2022-05-16 16:53       ` Peter Maydell
2022-05-16 19:14         ` Richard Henderson
2022-05-16 19:22           ` Thomas Huth
2022-05-17  5:35             ` Richard Henderson
2022-05-17  5:40   ` Richard Henderson
2022-05-16 14:58 ` [PATCH 3/3] capstone: Remove the capstone submodule Thomas Huth
2022-05-17  5:42   ` Richard Henderson
2022-05-19 11:41   ` Peter Maydell
2022-05-23 12:15     ` Thomas Huth
2022-06-03  0:03       ` Richard Henderson
2022-06-03  0:56         ` Richard Henderson
2022-06-03  5:21           ` Thomas Huth
2022-06-03 13:48             ` Richard Henderson
2022-06-03 15:05               ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7274cba-130c-b2fb-f6fa-453787ad8bad@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).