From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01066C433DF for ; Tue, 30 Jun 2020 14:57:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C001220675 for ; Tue, 30 Jun 2020 14:57:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CzoEDv8K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C001220675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqHhW-0001ZT-EN for qemu-devel@archiver.kernel.org; Tue, 30 Jun 2020 10:57:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqHfm-0006ml-Gy for qemu-devel@nongnu.org; Tue, 30 Jun 2020 10:55:46 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:20970 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jqHfj-0002tW-0B for qemu-devel@nongnu.org; Tue, 30 Jun 2020 10:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593528941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/9CqsmazSkiQ5cdSQZeiW58RBdlj82sTgeipZ21J5sI=; b=CzoEDv8KFuqQL1wFq8E7vwRkQURQ/royqmVj0NsnmGYpMGUat8Eqz+jIA4SQguwinEpkTV km1OOxCPHcAA5aAeBbE6GMViu5waX7jI24TsxkeNBXr3LpnBFFpOoEYIG5GvPOjBa6FAMK EU7fIYm7zuY7yv8ycW302rcfD0Fy/jc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-jxdAdzk6Mia_0bXdQvw_mg-1; Tue, 30 Jun 2020 10:55:37 -0400 X-MC-Unique: jxdAdzk6Mia_0bXdQvw_mg-1 Received: by mail-ed1-f69.google.com with SMTP id d3so3541537edq.14 for ; Tue, 30 Jun 2020 07:55:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/9CqsmazSkiQ5cdSQZeiW58RBdlj82sTgeipZ21J5sI=; b=ttNBBeVGVnnVIECzfVNeqEgdGPNIv7zd1osV7rub6zTTCZEQ6CXmI7KRqn5Rsz9W5f RASeOtQxmki0kZZSqUD7CDfLtwHyvYzEJmXkx6IJzDo4j5U1WY9cq7mmy2r5M7p7S22I ScAf/8AhLeEzgAHYViHcLLiXcYdHQd01EpCmIFkAlmDDEEw9QsCvCo/kDL5qNSzcjl9I PLLwhgQ2iO7q/TZSFxlPTRSPB8acyzFIv4ShWr/9dLY/Irq5cvjsqE9DvrRqD15uW33b f3YPff3AeVNaIVAivDYHIJHaLbbRV76dr/Fi2NvSjwbRt5VnwPgPzj9+Lny8tUEKcUv0 dKdw== X-Gm-Message-State: AOAM532FaKtmUJR8FTJm8P4l77r3jQpg+6hjGAiLgwe3pvpgA7Ny2t6Y 8FJvAtHG9xzLE7B4xXyPgajAyDUAPOCyT8O4WzW51JwGvb0jXB7Lr9m3CTKagTAZQjGVBvYPOfD HhjojLU2UkcXm91s= X-Received: by 2002:aa7:c808:: with SMTP id a8mr21065880edt.259.1593528936397; Tue, 30 Jun 2020 07:55:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjT1eh4LmuibVV20gNATl63/XHJ/zZ+Sucq8PUefpWhZ+BghHeHTf2UESWZhBPZMc/cMuM7A== X-Received: by 2002:aa7:c808:: with SMTP id a8mr21065867edt.259.1593528936244; Tue, 30 Jun 2020 07:55:36 -0700 (PDT) Received: from [192.168.1.40] (1.red-83-51-162.dynamicip.rima-tde.net. [83.51.162.1]) by smtp.gmail.com with ESMTPSA id qn8sm2264777ejb.25.2020.06.30.07.55.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 07:55:35 -0700 (PDT) Subject: Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth" To: "Michael S. Tsirkin" , qemu-devel@nongnu.org References: <20200623145506.439100-1-mst@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Tue, 30 Jun 2020 16:55:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200623145506.439100-1-mst@redhat.com> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/30 01:11:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/23/20 4:56 PM, Michael S. Tsirkin wrote: > This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge initial bandwidth") > since that change makes unit tests much slower for all developers, while it's not > a robust way to fix migration tests. Migration tests need to find > a more robust way to discover a reasonable bandwidth without slowing > things down for everyone. > > Signed-off-by: Michael S. Tsirkin > > --- > tests/qtest/migration-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index dc3490c9fa..21ea5ba1d2 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void) > * without throttling. > */ > migrate_set_parameter_int(from, "downtime-limit", 1); > - migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */ > + migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */ > > /* To check remaining size after precopy */ > migrate_set_capability(from, "pause-before-switchover", true); > Acked-by: Philippe Mathieu-Daudé