From: Richard Henderson <richard.henderson@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>
Subject: Re: [PATCH v6 7/8] util: give a specific error message when O_DIRECT doesn't work
Date: Thu, 3 Sep 2020 09:55:22 -0700 [thread overview]
Message-ID: <c741505d-853e-774f-5adf-f28327a06678@linaro.org> (raw)
In-Reply-To: <20200903152210.1917355-8-berrange@redhat.com>
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> A common error scenario is to tell QEMU to use O_DIRECT in combination
> with a filesystem that doesn't support it. To aid users to diagnosing
> their mistake we want to provide a clear error message when this happens.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> util/osdep.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-09-03 16:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 15:22 [PATCH v6 0/8] block: improve error reporting for unsupported O_DIRECT Daniel P. Berrangé
2020-09-03 15:22 ` [PATCH v6 1/8] monitor: simplify functions for getting a dup'd fdset entry Daniel P. Berrangé
2020-09-03 16:51 ` Richard Henderson
2020-09-04 7:33 ` Markus Armbruster
2020-09-03 15:22 ` [PATCH v6 2/8] util: split off a helper for dealing with O_CLOEXEC flag Daniel P. Berrangé
2020-09-03 16:51 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 3/8] util: rename qemu_open() to qemu_open_old() Daniel P. Berrangé
2020-09-03 16:51 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 4/8] util: refactor qemu_open_old to split off variadic args handling Daniel P. Berrangé
2020-09-03 16:52 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 5/8] util: add Error object for qemu_open_internal error reporting Daniel P. Berrangé
2020-09-03 16:53 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 6/8] util: introduce qemu_open and qemu_create with " Daniel P. Berrangé
2020-09-03 16:54 ` Richard Henderson
2020-09-03 15:22 ` [PATCH v6 7/8] util: give a specific error message when O_DIRECT doesn't work Daniel P. Berrangé
2020-09-03 16:55 ` Richard Henderson [this message]
2020-09-03 15:22 ` [PATCH v6 8/8] block/file: switch to use qemu_open/qemu_create for improved errors Daniel P. Berrangé
2020-09-03 16:56 ` Richard Henderson
2020-09-10 13:07 ` [PATCH v6 0/8] block: improve error reporting for unsupported O_DIRECT Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c741505d-853e-774f-5adf-f28327a06678@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).