From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Chenyi Qiang" <chenyi.qiang@intel.com>,
"Binbin Wu" <binbin.wu@linux.intel.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Isaku Yamahata" <isaku.yamahata@intel.com>
Subject: Re: [PATCH 3/3] i386/tdx: handle TDG.VP.VMCALL<GetQuote>
Date: Fri, 20 Jun 2025 16:02:05 +0800 [thread overview]
Message-ID: <c7489032-d1bc-4ce0-9509-fae53d0a8bd8@intel.com> (raw)
In-Reply-To: <CABgObfYpkWDLtiJ3gAb8ouExON2q9BmB1NNMj6jyQ4Wh17rGKw@mail.gmail.com>
On 6/20/2025 3:47 PM, Paolo Bonzini wrote:
> On Fri, Jun 20, 2025 at 8:47 AM Xiaoyao Li <xiaoyao.li@intel.com> wrote:
>>> +void tdx_handle_get_quote(X86CPU *cpu, struct kvm_run *run)
>>
>> The previous version of mine, defined the return type as int, because it
>> wants to stop the QEMU when it hits the failure of
>> address_space_read/write. However, this patch returns
>> TDG_VP_VMCALL_INVALID_OPERAND to TD guest for such cases.
>>
>> Shouldn't the failure of address_space_read/write be treated as QEMU
>> internal error?
>
> The operands are provided by the guest, therefore I think it's an
> invalid operand error.
So address_space_read/write() itself won't fail when the address is
good, e.g., a valid memory address?
If so, I'm OK with it.
> Paolo
>
next prev parent reply other threads:[~2025-06-20 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 20:33 [RFC PATCH 0/3] TDX attestation support Paolo Bonzini
2025-06-19 20:33 ` [PATCH 1/3] update Linux headers to v6.16-rc3 Paolo Bonzini
2025-06-19 20:33 ` [PATCH 2/3] i386/tdx: handle TDG.VP.VMCALL<GetTdVmCallInfo> Paolo Bonzini
2025-06-19 20:33 ` [PATCH 3/3] i386/tdx: handle TDG.VP.VMCALL<GetQuote> Paolo Bonzini
2025-06-20 6:47 ` Xiaoyao Li
2025-06-20 7:47 ` Paolo Bonzini
2025-06-20 8:02 ` Xiaoyao Li [this message]
2025-06-20 8:09 ` Daniel P. Berrangé
2025-06-20 6:53 ` [RFC PATCH 0/3] TDX attestation support Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7489032-d1bc-4ce0-9509-fae53d0a8bd8@intel.com \
--to=xiaoyao.li@intel.com \
--cc=berrange@redhat.com \
--cc=binbin.wu@linux.intel.com \
--cc=chenyi.qiang@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).