qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jack Schwartz <jack.schwartz@oracle.com>
To: lcapitulino@redhat.com, armbru@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] query-block io-status display
Date: Mon, 4 Sep 2017 21:59:11 -0700	[thread overview]
Message-ID: <c749629a-3352-e2fc-812a-0a2489593c25@oracle.com> (raw)

Hi Luiz, Markus and everyone.

I am working on a qemu enhancement to display io-status in each 
query-block command, not just those for devices which have werror and/or 
rerror set to stop on error.

I'd like to verify the reasons behind the query-block command not 
reporting io-status if errors were reported to the guest or ignored.  A 
clue may come from the original code review email[1] for when this code 
was implemented:

   "In case of multiple errors being triggered in sequence only the first
    one is stored. The I/O status is always reset to BDRV_IOS_OK when the
    'cont' command is issued."

 From this I infer:
- io-status is shown when qemu is stopped onerror so errors can be seen 
in cases where a guest does not handle them.
- io-status is not shown when errors are already being handled by a guest
- io-status is not shown when errors are ignored

Is this correct?  Are there other subtleties/reasons as well?

     Thanks,
     Jack

[1] http://lists.nongnu.org/archive/html/qemu-devel/2011-09/msg02940.html

             reply	other threads:[~2017-09-05  4:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05  4:59 Jack Schwartz [this message]
2017-09-06  9:08 ` [Qemu-devel] query-block io-status display Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c749629a-3352-e2fc-812a-0a2489593c25@oracle.com \
    --to=jack.schwartz@oracle.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).