qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, gshan@redhat.com, eesposit@redhat.com,
	david@redhat.com, stefanha@redhat.com, cohuck@redhat.com,
	eauger@redhat.com
Subject: Re: [PATCH 4/8] edu: add smp_mb__after_rmw()
Date: Mon, 6 Mar 2023 16:06:26 +0100	[thread overview]
Message-ID: <c756dc04-0b37-a02c-7359-1636e1c7256c@redhat.com> (raw)
In-Reply-To: <CAFEAcA9SfBnBaAL3P2VPGh0Mjx59Fgp+RP1vdLtezruT=Sh4aA@mail.gmail.com>

On 3/6/23 15:24, Peter Maydell wrote:
>>> Why is this device even messing around with multiple
>>> threads and atomics anyway ??
>> Because it is an example of deferring device work to another thread,
>> just like on real hardware it may be deferred to an on-device
>> microcontroller or CPU.
> If we want to be able to do that, we should probably have
> infrastructure and higher-level primitives for it that
> don't require device authors to be super-familiar with
> QEMU's memory model and barriers... The fact there are only
> half a dozen other uses of qemu_thread_create() under hw/
> suggests that in practice we don't really need to do this
> very often, though.

Yes, you're totally right about that.  I have never needed this kind of 
higher-level primitive so I haven't thought much about what it would 
look like.

The usage of barriers isn't great, but all this patch does is correctness...

Paolo



  reply	other threads:[~2023-03-06 15:07 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 17:19 [PATCH 0/8] Fix missing memory barriers on ARM Paolo Bonzini
2023-03-03 17:19 ` [PATCH 1/8] qatomic: add smp_mb__before/after_rmw() Paolo Bonzini
2023-03-05 18:57   ` Richard Henderson
2023-03-05 21:00     ` Paolo Bonzini
2023-03-06 13:21   ` David Hildenbrand
2023-03-06 13:22     ` David Hildenbrand
2023-03-03 17:19 ` [PATCH 2/8] qemu-thread-posix: cleanup, fix, document QemuEvent Paolo Bonzini
2023-03-05 19:11   ` Richard Henderson
2023-03-06 13:28   ` David Hildenbrand
2023-03-03 17:19 ` [PATCH 3/8] qemu-thread-win32: " Paolo Bonzini
2023-03-05 19:14   ` Richard Henderson
2023-03-06 13:31   ` David Hildenbrand
2023-03-06 14:20     ` Paolo Bonzini
2023-03-06 14:32       ` David Hildenbrand
2023-03-06 15:17         ` Paolo Bonzini
2023-03-03 17:19 ` [PATCH 4/8] edu: add smp_mb__after_rmw() Paolo Bonzini
2023-03-05 19:14   ` Richard Henderson
2023-03-06 13:31   ` David Hildenbrand
2023-03-06 13:38   ` Peter Maydell
2023-03-06 14:10     ` Paolo Bonzini
2023-03-06 14:24       ` Peter Maydell
2023-03-06 15:06         ` Paolo Bonzini [this message]
2023-03-06 15:36           ` Peter Maydell
2023-03-03 17:19 ` [PATCH 5/8] util/async: add smp_mb__after_rmw() around BH enqueue/dequeue Paolo Bonzini
2023-03-05 19:32   ` Richard Henderson
2023-03-06  9:55     ` Paolo Bonzini
2023-03-03 17:19 ` [PATCH 6/8] aio-wait: switch to smp_mb__after_rmw() Paolo Bonzini
2023-03-05 19:32   ` Richard Henderson
2023-03-06 13:32   ` David Hildenbrand
2023-03-06 14:38   ` Stefan Hajnoczi
2023-03-03 17:19 ` [PATCH 7/8] qemu-coroutine-lock: add smp_mb__after_rmw() Paolo Bonzini
2023-03-05 19:36   ` Richard Henderson
2023-03-06 13:33   ` David Hildenbrand
2023-03-03 17:19 ` [PATCH 8/8] physmem: add missing memory barrier Paolo Bonzini
2023-03-05 19:40   ` Richard Henderson
2023-03-06 13:34   ` David Hildenbrand
2023-03-06 13:35 ` [PATCH 0/8] Fix missing memory barriers on ARM David Hildenbrand
2023-03-06 14:14   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c756dc04-0b37-a02c-7359-1636e1c7256c@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=eauger@redhat.com \
    --cc=eesposit@redhat.com \
    --cc=gshan@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).