From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E03ACC61DD8 for ; Mon, 16 Nov 2020 14:10:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C43A222B9 for ; Mon, 16 Nov 2020 14:10:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hshHmeWQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C43A222B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kefD4-000444-At for qemu-devel@archiver.kernel.org; Mon, 16 Nov 2020 09:10:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kef9u-0001RN-8u for qemu-devel@nongnu.org; Mon, 16 Nov 2020 09:07:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kef9r-0005j2-Nd for qemu-devel@nongnu.org; Mon, 16 Nov 2020 09:07:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605535622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eI58Xn7ECffTSueLPTFxdShtorAs8ktHqKcVEiU0eOU=; b=hshHmeWQHHXHcmiIVPN6oekVMwyD7ne25a9nljHlni518+23VJRdk/ji8V7mslDPPoCmkE AH8DuBW9g5cUUHO6B/7AC5F+blOdRGObSbyizFbd3x2uxgzQ4dJHegHDjFRV1LI1U9nevM /n4EVszVaRDYWdMhyCUsU1lPCvC/82g= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-DT7bsmMuMamrTUY7C3vKjg-1; Mon, 16 Nov 2020 09:07:00 -0500 X-MC-Unique: DT7bsmMuMamrTUY7C3vKjg-1 Received: by mail-wm1-f72.google.com with SMTP id y26so8775043wmj.7 for ; Mon, 16 Nov 2020 06:06:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eI58Xn7ECffTSueLPTFxdShtorAs8ktHqKcVEiU0eOU=; b=lUWlC79Wr+7++mqzs+WooPOgwEvi7hu7PYwBITXiOBnJS7uHqcswOvrw0HF2c0W7l9 ihwiy/psSSBv/cXzwTgXb4NlIUHcx9pFVAt3aJswv2py80D8WPSSRWrN6eb4F8QPpmHa AP0lVSfaFvKseMcMwRaPdBjJuiVxu9ht+7u0dOs8ASpb1Qq4ssGVpXhpbRIqeY9H9R16 1HjcWP0OvnqqMCRsHIJ2aH9nAPGD3PfKN4iJtKQJHkHOZzG0b8XF7gCzLwQf1FyccViw W55BxJvyi3FcVpd+npAtY820Cqz3OMmM4mAwDH5gekPHhTolEdTXuXyVrqz06H+ktkJC yiTw== X-Gm-Message-State: AOAM5305rTeXyzAG3O+0cnWzAT8YkuklsNpn/zLiCIB0BVViaC0vRq7o mlJo3W11nT6yXy/hiVi8/1BUTrL83tfDJOFglfikcP7B9j+DcOqArhuCZ1NYCaVy5dS4bgYcQBE WPMYQNr0BlSnRlm4= X-Received: by 2002:adf:ebc6:: with SMTP id v6mr18628917wrn.427.1605535618782; Mon, 16 Nov 2020 06:06:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZVudP8MfWzLF4BM3IKXTOaHXjLIYGK/PwmWTKm/JzM2xRM/3DTMS6KqqF09FjK5R/dbngFw== X-Received: by 2002:adf:ebc6:: with SMTP id v6mr18628885wrn.427.1605535618589; Mon, 16 Nov 2020 06:06:58 -0800 (PST) Received: from [192.168.1.36] (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id v2sm22611524wrm.96.2020.11.16.06.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2020 06:06:58 -0800 (PST) Subject: Re: [PATCH v2] json: Fix a memleak in parse_pair() To: Markus Armbruster , Alex Chen References: <20201113145525.85151-1-alex.chen@huawei.com> <7412CDE03601674DA8197E2EBD8937E83BA6762C@dggemm511-mbs.china.huawei.com> <87eektkdjw.fsf@dusky.pond.sub.org> <895daa42-e241-ff9c-6f55-a369ccfe9eb9@redhat.com> <5FB27D08.2070600@huawei.com> <87wnylieln.fsf@dusky.pond.sub.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 16 Nov 2020 15:06:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87wnylieln.fsf@dusky.pond.sub.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 22:35:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "Chenqun \(kuhn\)" , "qemu-devel@nongnu.org" , Zhanghailiang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/16/20 3:03 PM, Markus Armbruster wrote: > Alex Chen writes: > >> On 2020/11/16 19:43, Philippe Mathieu-Daudé wrote: >>> On 11/16/20 7:42 AM, Markus Armbruster wrote: >>>> "Chenqun (kuhn)" writes: >>>> >>>>>> -----Original Message----- >>>>>> From: Chenzhendong (alex) >>>>>> Sent: Friday, November 13, 2020 10:55 PM >>>>>> To: armbru@redhat.com >>>>>> Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org; >>>>>> qemu-trivial@nongnu.org; Zhanghailiang ; >>>>>> Chenqun (kuhn) >>>>>> Subject: [PATCH v2] json: Fix a memleak in parse_pair() >>>>>> >>>>>> In qobject_type(), NULL is returned when the 'QObject' returned from >>>>>> parse_value() is not of QString type, and this 'QObject' memory will leaked. >>>>>> So we need to first cache the 'QObject' returned from parse_value(), and finally >>>>>> free 'QObject' memory at the end of the function. >>>>>> Also, we add a testcast about invalid dict key. >>>>>> >>>>>> The memleak stack is as follows: >>>>>> Direct leak of 32 byte(s) in 1 object(s) allocated from: >>>>>> #0 0xfffe4b3c34fb in __interceptor_malloc (/lib64/libasan.so.4+0xd34fb) >>>>>> #1 0xfffe4ae48aa3 in g_malloc (/lib64/libglib-2.0.so.0+0x58aa3) >>>>>> #2 0xaaab3557d9f7 in qnum_from_int >>>>>> /Images/source_org/qemu_master/qemu/qobject/qnum.c:25 >>>>>> #3 0xaaab35584d23 in parse_literal >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:511 >>>>>> #4 0xaaab35584d23 in parse_value >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:554 >>>>>> #5 0xaaab35583d77 in parse_pair >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:270 >>>>>> #6 0xaaab355845db in parse_object >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:327 >>>>>> #7 0xaaab355845db in parse_value >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:546 >>>>>> #8 0xaaab35585b1b in json_parser_parse >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:580 >>>>>> #9 0xaaab35583703 in json_message_process_token >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-streamer.c:92 >>>>>> #10 0xaaab355ddccf in json_lexer_feed_char >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-lexer.c:313 >>>>>> #11 0xaaab355de0eb in json_lexer_feed >>>>>> /Images/source_org/qemu_master/qemu/qobject/json-lexer.c:350 >>>>>> #12 0xaaab354aff67 in tcp_chr_read >>>>>> /Images/source_org/qemu_master/qemu/chardev/char-socket.c:525 >>>>>> #13 0xfffe4ae429db in g_main_context_dispatch >>>>>> (/lib64/libglib-2.0.so.0+0x529db) >>>>>> #14 0xfffe4ae42d8f (/lib64/libglib-2.0.so.0+0x52d8f) >>>>>> #15 0xfffe4ae430df in g_main_loop_run (/lib64/libglib-2.0.so.0+0x530df) >>>>>> #16 0xaaab34d70bff in iothread_run >>>>>> /Images/source_org/qemu_master/qemu/iothread.c:82 >>>>>> #17 0xaaab3559d71b in qemu_thread_start >>>>>> /Images/source_org/qemu_master/qemu/util/qemu-thread-posix.c:519 >>>>>> >>> ... >>>> >>>> Queued, thanks! >>> >>> If possible can you s%/Images/source_org/qemu_master/qemu/%% to make >>> description more readable...? >>> >> >> Hi Philippe, >> I am sorry for that, considering that the patch has been queued, >> do I need to modify the commit message and send patch v3? As the patch was already queued, this was a comment for the maintainer, sorry for not being clear enough. > > I'll take care of it, no need to respin. Thanks! Thanks!