qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PULL 08/26] qobject: Move block-specific qdict code to block-qdict.c
Date: Tue, 19 Jun 2018 14:29:21 -0500	[thread overview]
Message-ID: <c770ff9b-7b3e-af61-2216-7132eec63c58@redhat.com> (raw)
In-Reply-To: <20180615142108.27814-9-kwolf@redhat.com>

On 06/15/2018 09:20 AM, Kevin Wolf wrote:
> From: Markus Armbruster <armbru@redhat.com>
> 
> Pure code motion, except for two brace placements and a comment
> tweaked to appease checkpatch.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   qobject/block-qdict.c     | 640 ++++++++++++++++++++++++++++++++++++++++++++
>   qobject/qdict.c           | 629 --------------------------------------------
>   tests/check-block-qdict.c | 655 ++++++++++++++++++++++++++++++++++++++++++++++
>   tests/check-qdict.c       | 642 ---------------------------------------------
>   MAINTAINERS               |   2 +
>   qobject/Makefile.objs     |   1 +
>   tests/Makefile.include    |   4 +
>   7 files changed, 1302 insertions(+), 1271 deletions(-)
>   create mode 100644 qobject/block-qdict.c
>   create mode 100644 tests/check-block-qdict.c

and missing a change to tests/.gitignore, so that 
tests/check-block-qdict now shows up as an untracked file on an in-tree 
build.

(We really should follow through with our threat of renaming all the 
tests to use a consistent suffix-based pattern, as it's much easier to 
gitignore a suffix than a prefix)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-06-19 19:29 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 14:20 [Qemu-devel] [PULL 00/26] Block layer patches Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 01/26] qemu-img: Fix assert when mapping unaligned raw file Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 02/26] iotests: Add test 221 to catch qemu-img map regression Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 03/26] jobs: fix stale wording Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 04/26] jobs: fix verb references in docs Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 05/26] rbd: Drop deprecated -drive parameter "filename" Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 06/26] iscsi: " Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 07/26] block: Add block-specific QDict header Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 08/26] qobject: Move block-specific qdict code to block-qdict.c Kevin Wolf
2018-06-19 19:29   ` Eric Blake [this message]
2018-06-15 14:20 ` [Qemu-devel] [PULL 09/26] block: Fix -blockdev for certain non-string scalars Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 10/26] block: Fix -drive " Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 11/26] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts() Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 12/26] block: Factor out qobject_input_visitor_new_flat_confused() Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 13/26] block: Make remaining uses of qobject input visitor more robust Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 14/26] block-qdict: Simplify qdict_flatten_qdict() Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 15/26] block-qdict: Tweak qdict_flatten_qdict(), qdict_flatten_qlist() Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 16/26] block-qdict: Clean up qdict_crumple() a bit Kevin Wolf
2018-06-15 14:20 ` [Qemu-devel] [PULL 17/26] block-qdict: Simplify qdict_is_list() some Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 18/26] check-block-qdict: Rename qdict_flatten()'s variables for clarity Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 19/26] check-block-qdict: Cover flattening of empty lists and dictionaries Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 20/26] block: Fix -blockdev / blockdev-add for empty objects and arrays Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 21/26] rbd: New parameter auth-client-required Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 22/26] rbd: New parameter key-secret Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 23/26] block: Remove deprecated -drive geometry options Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 24/26] block: Remove deprecated -drive option addr Kevin Wolf
2018-06-15 14:21 ` [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial Kevin Wolf
2018-06-22 11:38   ` Christian Borntraeger
2018-06-22 12:51     ` [Qemu-devel] request a revert for "block: Remove deprecated -drive option serial" (was block: Remove deprecated -drive option serial) Christian Borntraeger
2018-06-22 20:08       ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-06-22 12:55     ` [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial Kevin Wolf
2018-06-22 13:36       ` Christian Borntraeger
2018-06-22 14:00         ` Christian Borntraeger
2018-06-22 14:02         ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2018-06-22 14:25         ` [Qemu-devel] " Kevin Wolf
2018-06-22 14:31           ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2018-06-25  9:53             ` Daniel P. Berrangé
2018-06-25 11:41               ` Kevin Wolf
2018-06-25 11:45                 ` Peter Krempa
2018-07-02  8:04                   ` Kevin Wolf
2018-07-03 10:53                     ` Christian Borntraeger
2018-07-03 11:22                       ` Daniel P. Berrangé
2018-07-03 11:32                         ` Kevin Wolf
2018-07-03 11:35                           ` Peter Maydell
2018-07-03 12:38                             ` Christian Borntraeger
2018-07-03 11:35                           ` Daniel P. Berrangé
2018-07-04 13:02                           ` Cornelia Huck
2018-07-04 13:34                             ` Kevin Wolf
2018-07-04 13:43                               ` Daniel P. Berrangé
2018-07-04 14:23                                 ` Kevin Wolf
2018-07-04 13:52                               ` Christian Borntraeger
2018-07-04 13:58                               ` Cornelia Huck
2018-07-04 16:14                               ` Peter Maydell
2018-07-06 11:11                                 ` Cornelia Huck
2018-07-06 14:56                                   ` Kevin Wolf
2018-07-06 15:05                                     ` Daniel P. Berrangé
2018-07-06 15:10                                     ` Peter Maydell
2018-07-09  6:33                                       ` Markus Armbruster
2018-07-09 11:08                                         ` Cornelia Huck
2018-07-09 11:17                                           ` Daniel P. Berrangé
2018-07-12  6:32                                             ` Markus Armbruster
2018-07-12 15:47                                               ` Thomas Huth
2018-07-13 11:35                                                 ` Cornelia Huck
2018-07-16 10:06                                                   ` Kashyap Chamarthy
2018-07-16  9:33                                                 ` Daniel P. Berrangé
2018-07-09  7:29                                     ` Peter Krempa
2018-07-10  5:59                                       ` Markus Armbruster
2018-07-10 14:22                                         ` Cornelia Huck
2018-07-10 14:38                                           ` Kevin Wolf
2018-07-12  6:38                                             ` Markus Armbruster
2018-07-12  6:51                                               ` Markus Armbruster
2018-07-12  7:48                                                 ` Cornelia Huck
2018-07-12  9:05                                                   ` Kevin Wolf
2018-07-12 11:14                                                   ` Markus Armbruster
2018-07-12  7:00                                               ` Peter Krempa
2018-07-12 11:19                                                 ` Markus Armbruster
2018-07-10 14:39                                           ` Peter Krempa
2018-07-10 15:01                                             ` Cornelia Huck
2018-07-10 15:24                                               ` Peter Krempa
2018-07-11  6:53                                                 ` Thomas Huth
2018-07-11  7:24                                                   ` Cornelia Huck
2018-07-12  6:40                                                   ` Markus Armbruster
2018-07-12  6:59                                                 ` Markus Armbruster
2018-07-12  7:19                                                   ` Peter Krempa
2018-07-12 11:33                                                     ` Markus Armbruster
2018-07-10 17:01                                               ` Daniel P. Berrangé
2018-07-11 13:48                                               ` Kashyap Chamarthy
2018-07-10 15:09                                           ` Peter Maydell
2018-07-10 16:59                                             ` Daniel P. Berrangé
2018-07-09  6:58                                   ` Thomas Huth
2018-07-09 11:58                                     ` Cornelia Huck
2018-06-22 14:38           ` [Qemu-devel] " Christian Borntraeger
2018-06-22 14:47             ` Peter Maydell
2018-06-22 15:01             ` Kevin Wolf
2018-06-22 15:50               ` Christian Borntraeger
2018-06-22 15:40           ` Daniel P. Berrangé
2018-06-22 17:54             ` Kevin Wolf
2018-06-25 11:18               ` Daniel P. Berrangé
2018-06-25 10:01             ` Peter Maydell
2018-06-25 10:31               ` Peter Krempa
2018-06-25 10:35                 ` Peter Maydell
2018-06-25  7:44           ` Thomas Huth
2018-06-22 14:19       ` Markus Armbruster
2018-06-22 14:25         ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2018-06-22 14:30           ` Daniel P. Berrangé
2018-06-22 15:00             ` Eric Blake
2018-06-25  7:16       ` Peter Krempa
2018-06-25  8:23         ` Thomas Huth
2018-06-25  9:04           ` Daniel P. Berrangé
2018-06-15 14:21 ` [Qemu-devel] [PULL 26/26] block: Remove dead deprecation warning code Kevin Wolf
2018-06-15 16:28 ` [Qemu-devel] [PULL 00/26] Block layer patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c770ff9b-7b3e-af61-2216-7132eec63c58@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).