From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 344CAC25B7C for ; Thu, 23 May 2024 23:33:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAHvu-00057z-HJ; Thu, 23 May 2024 19:33:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAHvt-00057V-Gq for qemu-devel@nongnu.org; Thu, 23 May 2024 19:33:13 -0400 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAHvr-0002fM-DN for qemu-devel@nongnu.org; Thu, 23 May 2024 19:33:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716507188; bh=eO7dEvyWIkf7WwMRhor6XkGHCZgQ5cD9t/czNqxbW7U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lzsXPURRrQWIrSKfTu7ivkQkCmvxprBV+2lOxEmOc5L3Yf3iNvmbqRlQyafFuop7m 8RtqIz8txmy5jLh5Rvoo0NPPm7rrDdjwxtqOrmO7+F/5SRFmG6IA8f7incc6/OHbWJ 1KLKfFaDUWI7z7Di3ZnIaPWzR3w8XqPqoyF1swUGvkMl1/29LNZMP6JKk8xZK29xHT +4vIJJk2k+y5PlSQzHIaf5d9z1CvpmJltisI70qgkyg8NnwZVOfroPIET8exGsCDba NHswPJmfxqCJKnc0EhoPX3aJptSXphnOYpU1TTSGtNI4yVbUTOTIem3O+3SF3a1Iz3 khvHHnzNiiC3A== Received: from [100.109.49.129] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 4DB033782178; Thu, 23 May 2024 23:33:06 +0000 (UTC) Message-ID: Date: Fri, 24 May 2024 02:33:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 13/13] virtio-gpu: Support Venus context To: Manos Pitsidianakis , qemu-devel@nongnu.org, Akihiko Odaki , Huang Rui , =?UTF-8?Q?Marc-Andr_=C3=A9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud_=C3=A9?= , Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Antonio Caggiano , "Dr . David Alan Gilbert" , Robert Beckett , Gert Wollny , =?UTF-8?Q?Alex_Benn_=C3=A9_e?= Cc: Gurchetan Singh , ernunes@redhat.com, Alyssa Ross , =?UTF-8?Q?Roger_Pau_Monn_=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?Q?Christian_K_=C3=B6_nig?= , Xenia Ragiadakou , Pierre-Eric Pelloux-Prayer , Honglei Huang , Julia Zhang , Chen Jiqian , Yiwei Zhang References: <20240519212712.2605419-1-dmitry.osipenko@collabora.com> <20240519212712.2605419-14-dmitry.osipenko@collabora.com> Content-Language: en-US From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1098:ed:100::25; envelope-from=dmitry.osipenko@collabora.com; helo=madrid.collaboradmins.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/23/24 10:18, Manos Pitsidianakis wrote: >> #define virtio_gpu_hostmem_enabled(_cfg) \ >>     (_cfg.hostmem > 0) >> +#define virtio_gpu_venus_enabled(_cfg) \ >> +    (_cfg.flags & (1 << VIRTIO_GPU_FLAG_VENUS_ENABLED)) >> > > Can we have both venus and rutabaga enabled on the same virtio-gpu > device? How would that work? It seems to me they should be mutually > exclusive. virtio-gpu-gl and virtio-gpu-rutabaga are separate device types. You can't enable venus for rutabaga device because it doesn't support venus and vice versa, Qemu will tell you that flag is invalid. -- Best regards, Dmitry