Re: [PATCH] configure / util: Auto-detect the availability of openpty()

[Thomas Huth <thuth@redhat.com>]

On 02/07/2020 16.46, Daniel P. Berrangé wrote:
> On Thu, Jul 02, 2020 at 04:39:55PM +0200, Thomas Huth wrote:
>> Recent versions of Solaris (v11.4) now feature an openpty() function,
>> too, causing a build failure since we ship our own implementation of
>> openpty() for Solaris in util/qemu-openpty.c so far. Since there are
>> now both variants available in the wild, with and without this function,
>> let's introduce a proper HAVE_OPENPTY define for this to fix the build
>> failure.
> 
> 11.4 has been out since Aug 2018
> 
> The previous verison of solaris  11.3 was from Oct 2015, with EOL
> in Oct 2020 [1].
> 
> Solaris isn't an officially supported platform for QEMU, but if it
> was, then we'd probably consider it a long life distro, and thus
> consider 11.3 to be out of scope for QEMU by now.
> 
> IOW, instead of checking for openpty being missing, I think there's
> a decent argument to be made that we can just assume openpty exists,
> and delete the old solaris compat code entirely.

I'd normally agree, but according to Peter, illumos also does not have 
this function yet:

  https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09276.html

... so I think we should keep it around for a little bit longer until at 
least the open source versions of Solaris have that function, too.
(Maybe someone will still finally provide a VM based on one of the 
illumos distros for our regression tests...?)

  Thomas