From: David Hildenbrand <david@redhat.com>
To: Auger Eric <eric.auger@redhat.com>, qemu-devel@nongnu.org
Cc: Pankaj Gupta <pagupta@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Luiz Capitulino <lcapitul@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v4 16/24] memory-device: trace when pre_assigning/assigning/unassigning addresses
Date: Mon, 1 Oct 2018 10:21:21 +0200 [thread overview]
Message-ID: <c7c561ea-7b14-b943-68cd-5392ecda40e0@redhat.com> (raw)
In-Reply-To: <2c164355-1592-a785-b761-463f00dee259@redhat.com>
>> # hw/mem/pc-dimm.c
>> mhp_pc_dimm_assigned_slot(int slot) "%d"
>> -mhp_pc_dimm_assigned_address(uint64_t addr) "0x%"PRIx64
>> +# hw/mem/memory-device.c
>> +memory_device_pre_assign_address(uint64_t addr) "0x%"PRIx64
>> +memory_device_assign_address(uint64_t addr) "0x%"PRIx64
>> +memory_device_unassign_address(uint64_t addr) "0x%"PRIx64
> In case we use several memory devices, wouldn't it make sense to pass
> the mr name or id as well to uniquely identify the device?
>
> nit: For debugging purpose it would look simpler to me to use the
> original function name for the associated trace (all the more so there
> is a single trace within) than the "assign_address" naming.
>
Both points make sense. I guess I'll move this patch behind
"memory-device: add class function get_device_id()", so I can directly
use get_device_id().
Thanks!
> Thanks
>
> Eric
>>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-10-01 8:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180926094219.20322-1-david@redhat.com>
[not found] ` <20180926094219.20322-9-david@redhat.com>
[not found] ` <df729c85-6fa1-93d7-c91e-7d3738fbf38f@redhat.com>
2018-10-01 8:13 ` [Qemu-devel] [PATCH v4 08/24] memory-device: document MemoryDeviceClass David Hildenbrand
2018-10-01 10:40 ` Auger Eric
[not found] ` <20180926094219.20322-15-david@redhat.com>
[not found] ` <99ab8baf-37c9-2df1-7292-8e0ac4f31137@redhat.com>
2018-10-01 8:15 ` [Qemu-devel] [PATCH v4 14/24] memory-device: complete factoring out plug handling David Hildenbrand
2018-10-01 8:18 ` David Hildenbrand
2018-10-01 9:01 ` Igor Mammedov
[not found] ` <20180926094219.20322-17-david@redhat.com>
[not found] ` <2c164355-1592-a785-b761-463f00dee259@redhat.com>
2018-10-01 8:21 ` David Hildenbrand [this message]
[not found] ` <20180926094219.20322-18-david@redhat.com>
[not found] ` <9be6d517-615d-34ef-f6f4-4d478ef21944@redhat.com>
2018-10-01 8:36 ` [Qemu-devel] [PATCH v4 17/24] memory-device: add class function get_device_id() David Hildenbrand
[not found] ` <20180926094219.20322-20-david@redhat.com>
2018-10-01 13:37 ` [Qemu-devel] [PATCH v4 19/24] virtio-pmem: prototype Igor Mammedov
[not found] ` <20180926094219.20322-22-david@redhat.com>
2018-10-01 18:57 ` [Qemu-devel] [PATCH v4 21/24] hmp: handle virtio-pmem when printing memory device infos Dr. David Alan Gilbert
[not found] ` <20180926094219.20322-23-david@redhat.com>
2018-10-01 18:59 ` [Qemu-devel] [PATCH v4 22/24] numa: handle virtio-pmem in NUMA stats Dr. David Alan Gilbert
[not found] ` <20180926094219.20322-19-david@redhat.com>
[not found] ` <20180927150141.60a6488a@redhat.com>
[not found] ` <dc5d7b2d-5b51-2c0b-aac7-ebf04a4e7859@redhat.com>
2018-10-01 13:24 ` [Qemu-devel] [PATCH v4 18/24] qdev: hotplug: provide do_unplug handler Igor Mammedov
2018-10-02 9:49 ` David Hildenbrand
2018-10-02 14:23 ` Igor Mammedov
2018-10-02 15:36 ` David Hildenbrand
2018-10-08 11:47 ` David Hildenbrand
2018-10-08 12:19 ` Igor Mammedov
2018-10-08 12:41 ` David Hildenbrand
2018-10-08 14:12 ` Igor Mammedov
2018-10-11 8:50 ` David Hildenbrand
2018-10-12 8:27 ` Igor Mammedov
2018-10-12 8:45 ` David Hildenbrand
2018-10-12 14:21 ` Igor Mammedov
2018-10-15 7:21 ` David Hildenbrand
2018-10-03 6:29 ` David Gibson
2018-10-03 17:21 ` David Hildenbrand
2018-10-04 15:59 ` Igor Mammedov
2018-10-05 7:40 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c561ea-7b14-b943-68cd-5392ecda40e0@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitul@redhat.com \
--cc=mst@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).