Re: [PATCH-for-9.0] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 19/3/24 03:16, Shiyang Ruan via wrote:
> From: Yao Xingtao <yaoxt.fnst@fujitsu.com>
> 
> In qemu monitor mode, when we use gpa2hva command to print the host
> virtual address corresponding to a guest physical address, if the gpa is
> not in RAM, the error message is below:
> 
> (qemu) gpa2hva 0x750000000
> Memory at address 0x750000000is not RAM
> 
> a space is missed between '0x750000000' and 'is'.
> 
> Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
> ---
>   monitor/hmp-cmds-target.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
> index 9338ae8440..ff01cf9d8d 100644
> --- a/monitor/hmp-cmds-target.c
> +++ b/monitor/hmp-cmds-target.c
> @@ -261,7 +261,7 @@ void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
>       }
>   
>       if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) {
> -        error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not RAM", addr);
> +        error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr);
>           memory_region_unref(mrs.mr);
>           return NULL;
>       }

Fixes: e9628441df ("hmp: gpa2hva and gpa2hpa hostaddr command")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>