From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5B9C433E0 for ; Tue, 12 Jan 2021 00:13:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A23F122D37 for ; Tue, 12 Jan 2021 00:13:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A23F122D37 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz7JN-0001au-M5 for qemu-devel@archiver.kernel.org; Mon, 11 Jan 2021 19:13:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz7E3-000721-HB for qemu-devel@nongnu.org; Mon, 11 Jan 2021 19:07:57 -0500 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:34825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz7E0-0004Zn-7C for qemu-devel@nongnu.org; Mon, 11 Jan 2021 19:07:55 -0500 Received: by mail-pg1-x532.google.com with SMTP id n7so246670pgg.2 for ; Mon, 11 Jan 2021 16:07:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B4R9c4QGGtVFWzG5gQIOM9OZ64Swp1/U+9Tebu3m9Rg=; b=lj25ddbbf1k3byjAibmah1THDxMzi+F4XrQB6wgzMc2y7jT2j3vsO5ktjpL8btfMKg M7hfz2Fz0X98aYBwhd4/zC7Z8er2fto5Wm4bwLkmWRS1OTc/Y5WhR7DynLpBrlzWnDqH BJZpQKjzc4/GkTISLEPtNGQp1UyXSdrsKjYomEkgQvi9CyW9r+v+qF2El+//pQ3hzfc9 1D48QYa6dslhcv7NwcO1zY4eKdFaCaY+oCGlZnC7HsODRY/zrjETQest4pO8tpSshEwr 1Ps4gKqJZpogergUPRtlesJ9ex6xj3NeWNEECfqfz0u27wMKbhHtyDUbSLe9t+1ubxmK n2Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B4R9c4QGGtVFWzG5gQIOM9OZ64Swp1/U+9Tebu3m9Rg=; b=QX/Kxqn+OkdlfOmVy5vh2vWbDOIiZFAW9H3uug1dIOUVITpyKNkmNehiq473Pry+RW LSn+/lxx7NA1fl64si+VuXwWKlIXErmnF/lKOTKlRIOCMXSvP4m5b9t8DqoywDjC/80m 4MceIgQ0GE6qTRQNi7nj2AEjCJjTZ1r5DqPRuzjN0eimGU1qgjapKiQlS8i4+KJb8tU4 ZPRQIPPC99ai44AR0s6TP0OjKYVCGpAyqIVfNndx0o2gCEa7isjbRUZavVQtGZyz+qhQ kP7IhHcqhifJuHvJMEQ0r3YiqS0HcmO35Wi06MaIT4YlIqL4zL8a9XEOhMYCTYwOuXGA yokA== X-Gm-Message-State: AOAM531ttKfPcwIShi0V5E9W76cTZa1vj/LeWRnBr9LWrYLSUrBMpTkS 3xRraDUzdIl1IEe9a8H8dIqrPf4ntCAAYA== X-Google-Smtp-Source: ABdhPJzMuu2hE5MYH43BlTdw5laD+vz23jzLkLF9MJ+Bzq5Q3XCWusvWQe9TCSW+Qaw5bf9pMyUpog== X-Received: by 2002:a62:e314:0:b029:19e:4cc:dc6f with SMTP id g20-20020a62e3140000b029019e04ccdc6fmr1785969pfh.33.1610410070704; Mon, 11 Jan 2021 16:07:50 -0800 (PST) Received: from [10.25.18.119] (rrcs-173-197-107-21.west.biz.rr.com. [173.197.107.21]) by smtp.gmail.com with ESMTPSA id b17sm581477pjz.44.2021.01.11.16.07.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 16:07:49 -0800 (PST) Subject: Re: [PATCH 13/18] target/arm: generalize 2-stage page-walk condition To: remi.denis.courmont@huawei.com, qemu-arm@nongnu.org References: <3337797.iIbC2pHGDl@basile.remlab.net> <20201218103759.19929-13-remi.denis.courmont@huawei.com> From: Richard Henderson Message-ID: Date: Mon, 11 Jan 2021 14:07:46 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201218103759.19929-13-remi.denis.courmont@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/18/20 12:37 AM, remi.denis.courmont@huawei.com wrote: > From: Rémi Denis-Courmont > > The stage_1_mmu_idx() already effectively keeps track of which > translation regimes have two stages. Don't hard-code another test. > > Signed-off-by: Rémi Denis-Courmont > --- > target/arm/helper.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~