From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65A3C54F52 for ; Tue, 29 Sep 2020 20:39:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 318942074B for ; Tue, 29 Sep 2020 20:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FxqtGQu8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 318942074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNMPd-0002Li-1p for qemu-devel@archiver.kernel.org; Tue, 29 Sep 2020 16:39:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNMMT-0007eL-83 for qemu-devel@nongnu.org; Tue, 29 Sep 2020 16:36:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kNMMR-0005wv-0m for qemu-devel@nongnu.org; Tue, 29 Sep 2020 16:36:32 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601411790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NqSFfD7QAdpdGCC9Tkrleh4jcF2IKguhqbiW3VFzvOs=; b=FxqtGQu8BJZXeqvZ4t51vIwaJqcB72DyM6aYRLOBE/UgEWVHuX9y4VhCHn7L9RVrzC9K+C MwM0Z8cRD7OOFDEZva+XEztNnYfhmOwyi4lrhdGLUigvFY5FwcO4x/GUgWq8TRg18N64df 2S6nRoq/WT8lI8KaAnb8Q1V6WousYoo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-kwAJvauVNUSCzHAyq8Yzbg-1; Tue, 29 Sep 2020 16:36:26 -0400 X-MC-Unique: kwAJvauVNUSCzHAyq8Yzbg-1 Received: by mail-wr1-f72.google.com with SMTP id b7so2233699wrn.6 for ; Tue, 29 Sep 2020 13:36:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NqSFfD7QAdpdGCC9Tkrleh4jcF2IKguhqbiW3VFzvOs=; b=dLfnzkZXteOKaq9ZO6cnEA2hd7r/HhOoQaJ77MXDLgvHfj/EtUOchPXyprNy2v8gNk rBOKqzyK6JIE0tZxDJzR9cc9NkzN5XQjxxEtl3FZO9uH2kCTMNbyGbSzG3pBla+SbzsA K+WzgGXArgI2aczwMcIKWGFsO4LU9H6YbWxurQ+/nQwNI5veN8Mdf/6Uz02ki3e96lJf WyqQQKBbonRvjILNVWUHGM64ybaI0dNTIHRSB/YuT2tLCyr2Wldrgk4XmFbH4I2EoTtq GfgVkgf6bFPlvpycmiU0449zb1pqoflFaYQCNCGQ5l8eZy3yCrxDR++PAPaQti0agYXa mdWg== X-Gm-Message-State: AOAM530OggiYrvMCF5DqFNJJ0DP6XIaUuFrxzjG0+i0pdsxnMXacgjEr D1u/mNjCotMFsVAV0x+CTkU4CaDtOvvw6MIz0Yr7euE709P7aOirsq2k9j/Q0QhSIK6sMX3msfq QXE1wFyeGHZWJFqE= X-Received: by 2002:a7b:cd8b:: with SMTP id y11mr6493722wmj.172.1601411784989; Tue, 29 Sep 2020 13:36:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv0Qp/AB5UWqp2781fUzVCZRy+PT3mxWTnB5vOG1PeqC+ApznMQVxwvZ7ue/IGIzRG4PzifA== X-Received: by 2002:a7b:cd8b:: with SMTP id y11mr6493703wmj.172.1601411784776; Tue, 29 Sep 2020 13:36:24 -0700 (PDT) Received: from [192.168.1.36] (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id n21sm6788855wmi.21.2020.09.29.13.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 13:36:24 -0700 (PDT) Subject: Re: [PATCH v3 17/19] hw/arm: Automatically select the 'virt' machine on KVM To: Peter Maydell References: <20200316160634.3386-1-philmd@redhat.com> <20200316160634.3386-18-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Tue, 29 Sep 2020 22:36:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/29 02:22:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , kvm-devel , Richard Henderson , QEMU Developers , qemu-arm , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/29/20 10:11 PM, Peter Maydell wrote: > On Tue, 29 Sep 2020 at 21:06, Peter Maydell wrote: >> >> On Mon, 16 Mar 2020 at 16:08, Philippe Mathieu-Daudé wrote: >>> >>> When building a KVM-only QEMU, the 'virt' machine is a good >>> default :) >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> hw/arm/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig >>> index d0903d8544..8e801cd15f 100644 >>> --- a/hw/arm/Kconfig >>> +++ b/hw/arm/Kconfig >>> @@ -1,5 +1,6 @@ >>> config ARM_VIRT >>> bool >>> + default y if KVM >>> imply PCI_DEVICES >>> imply TEST_DEVICES >>> imply VFIO_AMD_XGBE >> >> What does this actually do ? Why should the choice of >> accelerator affect what boards we pull in by default? > > Put another way, our current default is "build everything", > so "default y if ..." on a board is a no-op... Yes, the problem if I don't restrict to KVM, when using the Xen accelerator odd things occur (using configure --enable-xen --disable-tcg --disable-kvm): Compiling C object libqemu-i386-softmmu.fa.p/hw_cpu_a15mpcore.c.o hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory See https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions#Use_of_qemu-system-i386_on_ARM We can't have the 'virt' machine automatically selected if Xen is the only accelerator... I'm looking for a simple way to avoid modifying the Xen code. > > -- PMM >