From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE57C7618F for ; Fri, 19 Jul 2019 15:55:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A96E2186A for ; Fri, 19 Jul 2019 15:55:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A96E2186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoVEV-0002Ok-Uj for qemu-devel@archiver.kernel.org; Fri, 19 Jul 2019 11:55:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36577) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoVEF-0001zH-VC for qemu-devel@nongnu.org; Fri, 19 Jul 2019 11:55:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoVDz-0000Zx-Lq for qemu-devel@nongnu.org; Fri, 19 Jul 2019 11:55:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1195) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoVDL-0006w1-Rz; Fri, 19 Jul 2019 11:54:40 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F81B3B72A; Fri, 19 Jul 2019 15:49:44 +0000 (UTC) Received: from [10.3.116.46] (ovpn-116-46.phx2.redhat.com [10.3.116.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6B28620BD; Fri, 19 Jul 2019 15:49:31 +0000 (UTC) To: Aarushi Mehta , qemu-devel@nongnu.org References: <20190719133530.28688-1-mehta.aaru20@gmail.com> <20190719133530.28688-3-mehta.aaru20@gmail.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Fri, 19 Jul 2019 10:49:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190719133530.28688-3-mehta.aaru20@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o8m0xGw5TFhtsItmc26FnakssPKxrcWul" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 19 Jul 2019 15:49:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v6 02/14] qapi/block-core: add option for io_uring X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Sergio Lopez , Markus Armbruster , Maxim Levitsky , saket.sinha89@gmail.com, Max Reitz , Stefan Hajnoczi , Paolo Bonzini , Stefan Hajnoczi , Julia Suvorova Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o8m0xGw5TFhtsItmc26FnakssPKxrcWul Content-Type: multipart/mixed; boundary="UvK0x123djierGr6eu41PfDefuMvBWZ7K"; protected-headers="v1" From: Eric Blake To: Aarushi Mehta , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Paolo Bonzini , Stefan Hajnoczi , Julia Suvorova , Sergio Lopez , saket.sinha89@gmail.com, Fam Zheng , Stefan Hajnoczi , Markus Armbruster , Maxim Levitsky , Kevin Wolf , Max Reitz Message-ID: Subject: Re: [PATCH v6 02/14] qapi/block-core: add option for io_uring References: <20190719133530.28688-1-mehta.aaru20@gmail.com> <20190719133530.28688-3-mehta.aaru20@gmail.com> In-Reply-To: <20190719133530.28688-3-mehta.aaru20@gmail.com> --UvK0x123djierGr6eu41PfDefuMvBWZ7K Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/19/19 8:35 AM, Aarushi Mehta wrote: > Only enumerates option for devices that support it >=20 > Signed-off-by: Aarushi Mehta > Reviewed-by: Stefan Hajnoczi > --- > qapi/block-core.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 0d43d4f37c..0a3d4ae7d2 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2792,11 +2792,13 @@ > # > # @threads: Use qemu's thread pool > # @native: Use native AIO backend (only Linux and Windows) > +# @io_uring: Use linux io_uring (since 4.1) I know you explained in an earlier revision why you chose 'io_uring' instead of the more typical QAPI spelling of 'io-uring' (namely, it matches the Linux kernel feature spelling). That explanation belongs in the commit message, rather than just the mailing list archives. > # > # Since: 2.9 > ## > { 'enum': 'BlockdevAioOptions', > - 'data': [ 'threads', 'native' ] } > + 'data': [ 'threads', 'native', > + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING= )' } ] } > =20 > ## > # @BlockdevCacheOptions: >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --UvK0x123djierGr6eu41PfDefuMvBWZ7K-- --o8m0xGw5TFhtsItmc26FnakssPKxrcWul Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0x5ooACgkQp6FrSiUn Q2rGcQf8DDlyk6lkpEuZcAOb8m24Izuv+NYrx2pFSeQCFElPmIlEQL+clsm9N5Co nQYP1PTN29aEXJYIqort7ElaT2k9N8WgdVQ23tJb/r9CAJuAcqpJtNuQVyla9+LN NKRiNII7gPDxcB+t6/C+01NrHBJhYSTN7z9bPJCcffWLryKjYFSO7Q6LV00QoJ2D AP4SZ9Enjl32LH/h568Ei5y3NSASQOwc9z37/Oc4QOHJW4GDmXHGNuyB0FSaX3Tc UPQZo5d09+dikdzwyIoOQ9596mY4RZt6XbGxqLCq/ihj7VdIzcbtT1iXAAbm2FIc ltgV9RscZ0xBH9GfLuyUhWxPpfDZ2g== =1SeO -----END PGP SIGNATURE----- --o8m0xGw5TFhtsItmc26FnakssPKxrcWul--