From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: David Edmondson <david.edmondson@oracle.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/2] elf_ops: correct loading of 32 bit PVH kernel
Date: Tue, 2 Mar 2021 11:31:20 +0100 [thread overview]
Message-ID: <c7e39cd9-1d9b-6eb6-f2dd-aa51455f8950@redhat.com> (raw)
In-Reply-To: <20210302090315.3031492-2-david.edmondson@oracle.com>
On 3/2/21 10:03 AM, David Edmondson wrote:
> Because sizeof(struct elf64_note) == sizeof(struct elf32_note),
> attempting to use the size of the currently defined struct elf_note as
> a discriminator for whether the object being loaded is 64 bit in
> load_elf() fails.
>
> Instead, take advantage of the existing glue parameter SZ, which is
> defined as 32 or 64 in the respective variants of load_elf().
>
> Fixes: 696aa04c84c6 ("elf-ops.h: Add get_elf_note_type()")
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
> include/hw/elf_ops.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-03-02 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 9:03 [PATCH 0/2] improve loading of 32 bit PVH kernels David Edmondson
2021-03-02 9:03 ` [PATCH 1/2] elf_ops: correct loading of 32 bit PVH kernel David Edmondson
2021-03-02 10:31 ` Philippe Mathieu-Daudé [this message]
2021-03-02 13:36 ` Stefano Garzarella
2021-03-02 14:26 ` Alex Bennée
2021-03-02 9:03 ` [PATCH 2/2] x86/pvh: extract only 4 bytes of start address for 32 bit kernels David Edmondson
2021-03-02 13:54 ` Stefano Garzarella
2021-03-02 10:30 ` [PATCH 0/2] improve loading of 32 bit PVH kernels Philippe Mathieu-Daudé
2021-03-02 14:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e39cd9-1d9b-6eb6-f2dd-aa51455f8950@redhat.com \
--to=philmd@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).