From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3763C433DB for ; Tue, 2 Mar 2021 10:36:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6993A64F07 for ; Tue, 2 Mar 2021 10:36:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6993A64F07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH2OR-0005al-W5 for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 05:36:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH2JL-0006sv-LC for qemu-devel@nongnu.org; Tue, 02 Mar 2021 05:31:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lH2JJ-0001zL-Sy for qemu-devel@nongnu.org; Tue, 02 Mar 2021 05:31:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614681085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=15oagbyyaakT3ieFVjWh7TVKlvC3zd1XGpa4FXqaKvs=; b=CjIDnszD78pygY3+CykZuBbaYBCKcCmb2GWnpvrivp+ccTEcapPJW9wCg4PqkaiqXDuyJ4 FCeAFaHaYytFxWEEGljGUWXSfjJScMxhz73rjwfT0O7Wfdk1hc+LSCcniYwMgkaqT/0gMb OyA3ksc+NiMySn69HXix5e6t8+XH4i0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-XW2-YlFWNd2IdtGBhs2bcQ-1; Tue, 02 Mar 2021 05:31:23 -0500 X-MC-Unique: XW2-YlFWNd2IdtGBhs2bcQ-1 Received: by mail-ed1-f72.google.com with SMTP id l6so10152613edn.22 for ; Tue, 02 Mar 2021 02:31:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=15oagbyyaakT3ieFVjWh7TVKlvC3zd1XGpa4FXqaKvs=; b=n6FtTV7xueTczYrJOyGcLWMw+gEDSXcgDmAPHoi4jz2CAMfLTbCQZvG9Wpgb0PMrN2 z04Tgscn+GxFX+eC/tRCWoIq/2xQ3QanZe08ROlztpAkqTUpIaZgE0mY6PNvu3L48pJ9 1pC/eBT2oOWrfSYNpcU+V3AMQG5a6BiU7Hq0kfci3nTXnDoLLKBj4IrPksj1U/WNKdOX VSCrYMP2v8eUomn/RWtlG4t03+U6ziBuu2TE0rMpYvfiNkIjBr4UQUYU1yyrUBWGdjbm ZjWebErsbFZn3FotQtdWz+JYUpgBoz+jkbVe79H9yULyAN4iPeEtDDaqATKhUuGuHJkQ A67w== X-Gm-Message-State: AOAM531aMmEysdOgTCaor04XJaAJSGtYZY09jiFY5rdytgRYYJbhH4H+ F89SAv7rFO70DQuo37xXCBziYXv0y8PNLm0y4i3BKp8ng+EwY/4A3O+4cXegpFKrztx19oldTDn CDIwpO3zbHiELR9A= X-Received: by 2002:a50:8a90:: with SMTP id j16mr19493091edj.334.1614681082333; Tue, 02 Mar 2021 02:31:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSyfrBQZD2S8kgb/GNlF+q8gGAS+DVnKVGqtvxUEBnSxmDMqwLa5F6iVUVJ16Eg92SIm1zUA== X-Received: by 2002:a50:8a90:: with SMTP id j16mr19493078edj.334.1614681082225; Tue, 02 Mar 2021 02:31:22 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id a3sm17758650ejv.40.2021.03.02.02.31.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Mar 2021 02:31:21 -0800 (PST) Subject: Re: [PATCH 1/2] elf_ops: correct loading of 32 bit PVH kernel To: David Edmondson , qemu-devel@nongnu.org References: <20210302090315.3031492-1-david.edmondson@oracle.com> <20210302090315.3031492-2-david.edmondson@oracle.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 2 Mar 2021 11:31:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210302090315.3031492-2-david.edmondson@oracle.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/2/21 10:03 AM, David Edmondson wrote: > Because sizeof(struct elf64_note) == sizeof(struct elf32_note), > attempting to use the size of the currently defined struct elf_note as > a discriminator for whether the object being loaded is 64 bit in > load_elf() fails. > > Instead, take advantage of the existing glue parameter SZ, which is > defined as 32 or 64 in the respective variants of load_elf(). > > Fixes: 696aa04c84c6 ("elf-ops.h: Add get_elf_note_type()") > Signed-off-by: David Edmondson > --- > include/hw/elf_ops.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé