From: Richard Henderson <richard.henderson@linaro.org>
To: Stafford Horne <shorne@gmail.com>,
QEMU Development <qemu-devel@nongnu.org>
Cc: Linux OpenRISC <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] target/openrisc: Allow fpcsr access in user mode
Date: Wed, 10 May 2023 17:13:03 +0100 [thread overview]
Message-ID: <c7e792c1-8229-8b6c-8e6a-1eda14d77c03@linaro.org> (raw)
In-Reply-To: <20230510153228.264954-2-shorne@gmail.com>
On 5/10/23 16:32, Stafford Horne wrote:
> void HELPER(mtspr)(CPUOpenRISCState *env, target_ulong spr, target_ulong rb)
> {
> -#ifndef CONFIG_USER_ONLY
> OpenRISCCPU *cpu = env_archcpu(env);
> +#ifndef CONFIG_USER_ONLY
> CPUState *cs = env_cpu(env);
Pulled cpu out if ifdef here...
> @@ -204,10 +220,22 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env, target_ulong rd,
> OpenRISCCPU *cpu = env_archcpu(env);
> CPUState *cs = env_cpu(env);
> int idx;
> +#else
> + OpenRISCCPU *cpu = env_archcpu(env);
> #endif
But replicated it here.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-05-10 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 15:32 [PATCH v2 0/3] OpenRISC updates for user space FPU Stafford Horne
2023-05-10 15:32 ` [PATCH v2 1/3] target/openrisc: Allow fpcsr access in user mode Stafford Horne
2023-05-10 16:13 ` Richard Henderson [this message]
2023-05-11 14:25 ` Stafford Horne
2023-05-10 15:32 ` [PATCH v2 2/3] target/openrisc: Set PC to cpu state on FPU exception Stafford Horne
2023-05-10 16:13 ` Richard Henderson
2023-05-10 15:32 ` [PATCH v2 3/3] target/openrisc: Setup FPU for detecting tininess before rounding Stafford Horne
2023-05-10 16:16 ` Richard Henderson
2023-05-11 14:33 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e792c1-8229-8b6c-8e6a-1eda14d77c03@linaro.org \
--to=richard.henderson@linaro.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).