[Qemu-devel] [PATCH v2] scsi: reset cdrom tray statuses on scsi_disk_reset

[Qemu-devel] [PATCH v2] scsi: reset cdrom tray statuses on scsi_disk_reset

[Pavel Hrdina]

Tray statuses should be also reset. Some guests may lock the tray and
right after resetting the guest it should be unlocked and closed. This
is done on power-on, reset and resume from suspend/hibernate on bare-metal.

This fix is already committed for IDE CD.
Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.

Test results on bare-metal:
  - on reset/power-on the CD-ROM tray is closed even before the monitor
    is turned on
  - on resume from suspend/hibernate the tray is also closed before
    the monitor is turned on

>From test results it seems that this behavior is OS and probably BIOS
independent.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 hw/scsi/scsi-disk.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index c8d2a99..02733dc 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1984,6 +1984,9 @@ static void scsi_disk_reset(DeviceState *dev)
         nb_sectors--;
     }
     s->qdev.max_lba = nb_sectors;
+    /* reset tray statuses */
+    s->tray_locked = 0;
+    s->tray_open = 0;
 }
 
 static void scsi_destroy(SCSIDevice *dev)
-- 
1.8.1.4

Re: [Qemu-devel] [PATCH v2] scsi: reset cdrom tray statuses on scsi_disk_reset

[Paolo Bonzini]

Il 20/05/2013 13:06, Pavel Hrdina ha scritto:
> Tray statuses should be also reset. Some guests may lock the tray and
> right after resetting the guest it should be unlocked and closed. This
> is done on power-on, reset and resume from suspend/hibernate on bare-metal.
> 
> This fix is already committed for IDE CD.
> Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.
> 
> Test results on bare-metal:
>   - on reset/power-on the CD-ROM tray is closed even before the monitor
>     is turned on
>   - on resume from suspend/hibernate the tray is also closed before
>     the monitor is turned on
> 
> From test results it seems that this behavior is OS and probably BIOS
> independent.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

Applied to scsi-next branch, thanks.

Paolo

> ---
>  hw/scsi/scsi-disk.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index c8d2a99..02733dc 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -1984,6 +1984,9 @@ static void scsi_disk_reset(DeviceState *dev)
>          nb_sectors--;
>      }
>      s->qdev.max_lba = nb_sectors;
> +    /* reset tray statuses */
> +    s->tray_locked = 0;
> +    s->tray_open = 0;
>  }
>  
>  static void scsi_destroy(SCSIDevice *dev)
>