From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: QEMU device refcounting when device creates a container MR
Date: Wed, 9 Mar 2022 11:40:15 +0100 [thread overview]
Message-ID: <c7f6ffef-8ce1-6ee1-9ad7-a90ed1b54122@gmail.com> (raw)
In-Reply-To: <CAFEAcA87VaeHzW4qbHn+UKjh9gMQbKNcN5ytXBS1MUPSapdhYw@mail.gmail.com>
Cc'ing David / Peter
On 9/3/22 11:33, Peter Maydell wrote:
> Hi; does anybody know how device reference counting is supposed
> to work when the device creates a "container" MemoryRegion which
> it then puts some of its own subregions in to?
>
> As far as I can see when you do memory_region_add_subregion it
> increases the refcount on the owner of the subregion. So if a
> device creates a container MR in its own init or realize method
> and adds sub-MRs that it owns to that container, this increases
> the refcount on the device permanently, and so the device won't
> ever be deinited.
>
> As a specific example, the usb-chipidea device does this in its
> init method, so if you run the arm device-introspect-test under
> leak-sanitizer it complains about a memory leak that happens
> when the device is put through the "init-introspect-deref" cycle.
>
> -- PMM
>
next prev parent reply other threads:[~2022-03-09 10:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 10:33 QEMU device refcounting when device creates a container MR Peter Maydell
2022-03-09 10:40 ` Philippe Mathieu-Daudé [this message]
2022-03-10 13:19 ` Peter Xu
2022-03-10 13:45 ` Peter Maydell
2022-03-11 2:19 ` Peter Xu
2022-03-09 16:21 ` Paolo Bonzini
2022-03-09 16:53 ` Peter Maydell
2022-03-09 16:56 ` Peter Maydell
2022-03-10 15:36 ` Igor Mammedov
2022-03-10 16:05 ` Peter Maydell
2022-03-10 16:30 ` Igor Mammedov
2022-03-10 17:11 ` Peter Maydell
2022-03-18 17:13 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f6ffef-8ce1-6ee1-9ad7-a90ed1b54122@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).