qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v4] target/xtensa: clean up unaligned access
Date: Wed, 19 May 2021 08:07:37 -0500	[thread overview]
Message-ID: <c7f930b5-3861-a126-864a-488ccf926203@linaro.org> (raw)
In-Reply-To: <20210519104557.16940-1-jcmvbkbc@gmail.com>

On 5/19/21 5:45 AM, Max Filippov wrote:
> Xtensa cores may or may not have hardware support for unaligned memory
> access. Remove TARGET_ALIGNED_ONLY=y from all xtensa configurations and
> pass MO_ALIGN in memory access flags for all operations that would raise
> an exception.
> Simplify use of gen_load_store_alignment by passing access size and
> alignment requirements in single parameter.
> Drop condition from xtensa_cpu_do_unaligned_access and replace it with
> assertion.
> Add a test.
> 
> Suggested-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> ---

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2021-05-19 13:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 10:45 [PATCH v4] target/xtensa: clean up unaligned access Max Filippov
2021-05-19 13:07 ` Richard Henderson [this message]
2021-05-19 14:19 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7f930b5-3861-a126-864a-488ccf926203@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).