qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH 02/10] plugins/loader: populate target_name with target_name()
Date: Tue, 25 Feb 2025 10:04:44 -0800	[thread overview]
Message-ID: <c80c2db8-f68d-4463-82e4-7f3780a81768@linaro.org> (raw)
In-Reply-To: <20250225110844.3296991-3-alex.bennee@linaro.org>

On 2/25/25 03:08, Alex Bennée wrote:
> We have a function we can call for this, lets not rely on macros that
> stop us building once.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   plugins/loader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/plugins/loader.c b/plugins/loader.c
> index 99686b5466..827473c8b6 100644
> --- a/plugins/loader.c
> +++ b/plugins/loader.c
> @@ -297,7 +297,7 @@ int qemu_plugin_load_list(QemuPluginList *head, Error **errp)
>       struct qemu_plugin_desc *desc, *next;
>       g_autofree qemu_info_t *info = g_new0(qemu_info_t, 1);
>   
> -    info->target_name = TARGET_NAME;
> +    info->target_name = target_name();
>       info->version.min = QEMU_PLUGIN_MIN_VERSION;
>       info->version.cur = QEMU_PLUGIN_VERSION;
>   #ifndef CONFIG_USER_ONLY

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  parent reply	other threads:[~2025-02-25 18:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 11:08 [PATCH 00/10] plugins: reduce total number of build objects Alex Bennée
2025-02-25 11:08 ` [PATCH 01/10] plugins/api: use tcg_ctx to get TARGET_PAGE_MASK Alex Bennée
2025-02-25 14:57   ` Philippe Mathieu-Daudé
2025-02-25 16:00   ` Richard Henderson
2025-02-25 11:08 ` [PATCH 02/10] plugins/loader: populate target_name with target_name() Alex Bennée
2025-02-25 14:58   ` Philippe Mathieu-Daudé
2025-02-25 18:04   ` Richard Henderson [this message]
2025-02-25 11:08 ` [PATCH 03/10] include/qemu: plugin-memory.h doesn't need cpu-defs.h Alex Bennée
2025-02-25 18:10   ` Richard Henderson
2025-02-25 11:08 ` [PATCH 04/10] plugins/api: clean-up the includes Alex Bennée
2025-02-25 18:14   ` Richard Henderson
2025-02-25 11:08 ` [PATCH 05/10] plugins/plugin.h: include queue.h Alex Bennée
2025-02-25 18:15   ` Richard Henderson
2025-02-25 11:08 ` [PATCH 06/10] plugins/loader: compile loader only once Alex Bennée
2025-02-25 18:18   ` Richard Henderson
2025-02-25 11:08 ` [PATCH 07/10] plugins/api: split out binary path/start/end/entry code Alex Bennée
2025-02-25 18:32   ` Richard Henderson
2025-02-25 18:57     ` Alex Bennée
2025-02-25 11:08 ` [PATCH 08/10] plugins/api: split out the vaddr/hwaddr helpers Alex Bennée
2025-02-25 18:40   ` Richard Henderson
2025-02-25 11:08 ` [PATCH 09/10] plugins/api: split out time control helpers Alex Bennée
2025-02-25 18:45   ` Richard Henderson
2025-02-25 11:08 ` [PATCH 10/10] plugins/api: build only once Alex Bennée
2025-02-25 18:46   ` Richard Henderson
2025-02-25 19:21 ` [PATCH 00/10] plugins: reduce total number of build objects Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c80c2db8-f68d-4463-82e4-7f3780a81768@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).