* Re: [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine
2019-01-30 15:45 [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine Thomas Huth
@ 2019-01-30 16:34 ` Philippe Mathieu-Daudé
2019-01-30 18:51 ` Cédric Le Goater
2019-01-30 22:38 ` David Gibson
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-30 16:34 UTC (permalink / raw)
To: Thomas Huth, qemu-ppc, David Gibson, Cédric Le Goater; +Cc: qemu-devel
On 1/30/19 4:45 PM, Thomas Huth wrote:
> The "XIVE" section is currently listed in the "PowerPC Machines"
> section, which is weird, since this is an interrupt controller
> device. Move it to the "Devices" section instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MAINTAINERS | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b334b53..eac36b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
> F: tests/rtas*
> F: tests/libqos/rtas*
>
> -XIVE
> -M: David Gibson <david@gibson.dropbear.id.au>
> -M: Cédric Le Goater <clg@kaod.org>
> -L: qemu-ppc@nongnu.org
> -S: Supported
> -F: hw/*/*xive*
> -F: include/hw/*/*xive*
> -
> virtex_ml507
> M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> L: qemu-ppc@nongnu.org
> @@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
> F: tests/fw_cfg-test.c
> T: git https://github.com/philmd/qemu.git fw_cfg-next
>
> +XIVE
> +M: David Gibson <david@gibson.dropbear.id.au>
> +M: Cédric Le Goater <clg@kaod.org>
> +L: qemu-ppc@nongnu.org
> +S: Supported
> +F: hw/*/*xive*
F: hw/intc/*xive*
> +F: include/hw/*/*xive*
I'd expect them in /intc/ like the source, but they are in:
F: include/hw/ppc/*xive*
> +
> Subsystems
> ----------
> Audio
>
With or without the paths updated:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine
2019-01-30 15:45 [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine Thomas Huth
2019-01-30 16:34 ` Philippe Mathieu-Daudé
@ 2019-01-30 18:51 ` Cédric Le Goater
2019-01-30 22:38 ` David Gibson
2 siblings, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2019-01-30 18:51 UTC (permalink / raw)
To: Thomas Huth, qemu-ppc, David Gibson; +Cc: qemu-devel
On 1/30/19 4:45 PM, Thomas Huth wrote:
> The "XIVE" section is currently listed in the "PowerPC Machines"
> section, which is weird, since this is an interrupt controller
> device.
( I wonder how XIVE should be classified, the logic is as big as
a core on the POWER9 processor. )
> Move it to the "Devices" section instead.
> Signed-off-by: Thomas Huth <thuth@redhat.com>
yes, looks good me.
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> MAINTAINERS | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b334b53..eac36b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
> F: tests/rtas*
> F: tests/libqos/rtas*
>
> -XIVE
> -M: David Gibson <david@gibson.dropbear.id.au>
> -M: Cédric Le Goater <clg@kaod.org>
> -L: qemu-ppc@nongnu.org
> -S: Supported
> -F: hw/*/*xive*
> -F: include/hw/*/*xive*
> -
> virtex_ml507
> M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> L: qemu-ppc@nongnu.org
> @@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
> F: tests/fw_cfg-test.c
> T: git https://github.com/philmd/qemu.git fw_cfg-next
>
> +XIVE
> +M: David Gibson <david@gibson.dropbear.id.au>
> +M: Cédric Le Goater <clg@kaod.org>
> +L: qemu-ppc@nongnu.org
> +S: Supported
> +F: hw/*/*xive*
> +F: include/hw/*/*xive*
> +
> Subsystems
> ----------
> Audio
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine
2019-01-30 15:45 [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine Thomas Huth
2019-01-30 16:34 ` Philippe Mathieu-Daudé
2019-01-30 18:51 ` Cédric Le Goater
@ 2019-01-30 22:38 ` David Gibson
2 siblings, 0 replies; 4+ messages in thread
From: David Gibson @ 2019-01-30 22:38 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-ppc, Cédric Le Goater, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]
On Wed, Jan 30, 2019 at 04:45:40PM +0100, Thomas Huth wrote:
> The "XIVE" section is currently listed in the "PowerPC Machines"
> section, which is weird, since this is an interrupt controller
> device. Move it to the "Devices" section instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Applied to ppc-for-4.0, thanks.
> ---
> MAINTAINERS | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b334b53..eac36b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
> F: tests/rtas*
> F: tests/libqos/rtas*
>
> -XIVE
> -M: David Gibson <david@gibson.dropbear.id.au>
> -M: Cédric Le Goater <clg@kaod.org>
> -L: qemu-ppc@nongnu.org
> -S: Supported
> -F: hw/*/*xive*
> -F: include/hw/*/*xive*
> -
> virtex_ml507
> M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> L: qemu-ppc@nongnu.org
> @@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
> F: tests/fw_cfg-test.c
> T: git https://github.com/philmd/qemu.git fw_cfg-next
>
> +XIVE
> +M: David Gibson <david@gibson.dropbear.id.au>
> +M: Cédric Le Goater <clg@kaod.org>
> +L: qemu-ppc@nongnu.org
> +S: Supported
> +F: hw/*/*xive*
> +F: include/hw/*/*xive*
> +
> Subsystems
> ----------
> Audio
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread