qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH] tests: increase timeout per instance of bios-tables-test
Date: Tue, 16 Jul 2024 19:44:41 +0200	[thread overview]
Message-ID: <c8208ef8-0a97-4aad-b49c-cbafb7ff5817@redhat.com> (raw)
In-Reply-To: <20240716090554-mutt-send-email-mst@kernel.org>

On 16/07/2024 15.06, Michael S. Tsirkin wrote:
> On Tue, Jul 16, 2024 at 02:59:30PM +0200, Igor Mammedov wrote:
>> CI often fails 'cross-i686-tci' job due to runner slowness
>> Log shows that test almost complete, with a few remaining
>> when bios-tables-test timeout hits:
>>
>>    19/270 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test
>>      TIMEOUT        610.02s   killed by signal 15 SIGTERM
>>    ...
>>    stderr:
>>    TAP parsing error: Too few tests run (expected 8, got 7)
>>
>> At the same time overall job running time is only ~30 out of 1hr allowed.
>>
>> Increase bios-tables-test instance timeout on 5min as a fix
>> for slow CI runners.
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> 
> We can't just keep increasing the timeout.
> The issue is checking wall time on a busy host,
> isn't it? Let's check CPU time instead.

The timeout setting comes from meson, not sure whether you can switch that 
easily to use CPU time instead of wall time?

Anyway, if the bios-tables-test is getting more and more complex, it's maybe 
not such a good idea to run it in a job that is using TCI ... Maybe it's 
best to remove aarch64-softmmu from the cross-i686-tci job?

  Thomas



  parent reply	other threads:[~2024-07-16 17:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 12:59 [PATCH] tests: increase timeout per instance of bios-tables-test Igor Mammedov
2024-07-16 13:06 ` Michael S. Tsirkin
2024-07-16 13:41   ` Peter Maydell
2024-07-16 14:48   ` Igor Mammedov
2024-07-16 17:44   ` Thomas Huth [this message]
2024-07-16 19:52     ` Peter Maydell
2024-07-22  7:35 ` Thomas Huth
2024-07-22  7:47   ` Michael S. Tsirkin
2024-07-22  9:50   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8208ef8-0a97-4aad-b49c-cbafb7ff5817@redhat.com \
    --to=thuth@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).