* [PATCH] hw/display/sm501: fix missing error-report.h
@ 2025-07-28 9:05 Clément Chigot
2025-07-28 9:07 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Clément Chigot @ 2025-07-28 9:05 UTC (permalink / raw)
To: qemu-devel
Cc: balaton, qemu-ppc, marcandre.lureau, berrange,
Clément Chigot
"qemu/error-report.h" was previously implicitly included. This is no
longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.
However, the issue predates this change as `error-report.h` should have
been included when the `warn_report` call was introduced.
Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
Signed-off-by: Clément Chigot <chigot@adacore.com>
---
hw/display/sm501.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 6d2f18684c..bc091b3c9f 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -26,6 +26,7 @@
#include "qemu/osdep.h"
#include "qemu/units.h"
#include "qapi/error.h"
+#include "qemu/error-report.h"
#include "qemu/log.h"
#include "qemu/module.h"
#include "hw/usb/hcd-ohci.h"
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/display/sm501: fix missing error-report.h
2025-07-28 9:05 [PATCH] hw/display/sm501: fix missing error-report.h Clément Chigot
@ 2025-07-28 9:07 ` Daniel P. Berrangé
2025-07-28 9:52 ` Philippe Mathieu-Daudé
2025-07-28 15:41 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2025-07-28 9:07 UTC (permalink / raw)
To: Clément Chigot; +Cc: qemu-devel, balaton, qemu-ppc, marcandre.lureau
On Mon, Jul 28, 2025 at 11:05:18AM +0200, Clément Chigot wrote:
> "qemu/error-report.h" was previously implicitly included. This is no
> longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.
>
> However, the issue predates this change as `error-report.h` should have
> been included when the `warn_report` call was introduced.
>
> Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
> hw/display/sm501.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 6d2f18684c..bc091b3c9f 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -26,6 +26,7 @@
> #include "qemu/osdep.h"
> #include "qemu/units.h"
> #include "qapi/error.h"
> +#include "qemu/error-report.h"
> #include "qemu/log.h"
> #include "qemu/module.h"
> #include "hw/usb/hcd-ohci.h"
> --
> 2.34.1
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hw/display/sm501: fix missing error-report.h
2025-07-28 9:05 [PATCH] hw/display/sm501: fix missing error-report.h Clément Chigot
2025-07-28 9:07 ` Daniel P. Berrangé
@ 2025-07-28 9:52 ` Philippe Mathieu-Daudé
2025-07-28 15:41 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-07-28 9:52 UTC (permalink / raw)
To: Clément Chigot, qemu-devel
Cc: balaton, qemu-ppc, marcandre.lureau, berrange
On 28/7/25 11:05, Clément Chigot wrote:
> "qemu/error-report.h" was previously implicitly included. This is no
> longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.
>
> However, the issue predates this change as `error-report.h` should have
> been included when the `warn_report` call was introduced.
>
> Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
> hw/display/sm501.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
and queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hw/display/sm501: fix missing error-report.h
2025-07-28 9:05 [PATCH] hw/display/sm501: fix missing error-report.h Clément Chigot
2025-07-28 9:07 ` Daniel P. Berrangé
2025-07-28 9:52 ` Philippe Mathieu-Daudé
@ 2025-07-28 15:41 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-07-28 15:41 UTC (permalink / raw)
To: Clément Chigot, qemu-devel
Cc: balaton, qemu-ppc, marcandre.lureau, berrange
On 28/7/25 11:05, Clément Chigot wrote:
> "qemu/error-report.h" was previously implicitly included. This is no
> longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.
>
> However, the issue predates this change as `error-report.h` should have
> been included when the `warn_report` call was introduced.
>
> Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
> hw/display/sm501.c | 1 +
> 1 file changed, 1 insertion(+)
Patch queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-28 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-28 9:05 [PATCH] hw/display/sm501: fix missing error-report.h Clément Chigot
2025-07-28 9:07 ` Daniel P. Berrangé
2025-07-28 9:52 ` Philippe Mathieu-Daudé
2025-07-28 15:41 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).