From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Xiaoyao Li <xiaoyao.li@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] target/i386: Use X86ASIdx_MEM in kvm_init()
Date: Thu, 16 Oct 2025 10:43:27 +0200 [thread overview]
Message-ID: <c82e0b7d-c22c-41b5-a9e8-757a590cf719@linaro.org> (raw)
In-Reply-To: <20251014094216.164306-3-xiaoyao.li@intel.com>
On 14/10/25 11:42, Xiaoyao Li wrote:
> When the patch introduces 'enum X86ADIdx'[0] got merged, it somehow
> missed the change to replace as id 0 with X86ASIdx_MEM in kvm_init().
>
> Change the leftover in kvm_init() to make the usage consistent.
>
> [0] https://lore.kernel.org/qemu-devel/20250730095253.1833411-3-xiaoyao.li@intel.com/
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> accel/kvm/kvm-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 58802f7c3cc1..3030c47d55b1 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -2800,7 +2800,7 @@ static int kvm_init(AccelState *as, MachineState *ms)
> s->memory_listener.listener.coalesced_io_del = kvm_uncoalesce_mmio_region;
>
> kvm_memory_listener_register(s, &s->memory_listener,
> - &address_space_memory, 0, "kvm-memory");
> + &address_space_memory, X86ASIdx_MEM, "kvm-memory");
NAck: this is a generic code use by multiple architectures.
next prev parent reply other threads:[~2025-10-16 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 9:42 [PATCH 0/2] x86/cpu: initialize SMM cpu address space for hotplugged cpus Xiaoyao Li
2025-10-14 9:42 ` [PATCH 1/2] i386/kvm/cpu: Init SMM cpu address space for hotplugged CPUs Xiaoyao Li
2025-10-14 9:42 ` [PATCH 2/2] target/i386: Use X86ASIdx_MEM in kvm_init() Xiaoyao Li
2025-10-16 8:43 ` Philippe Mathieu-Daudé [this message]
2025-10-16 9:23 ` Paolo Bonzini
2025-10-16 9:46 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c82e0b7d-c22c-41b5-a9e8-757a590cf719@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).