From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9793C0218D for ; Sun, 26 Jan 2025 21:15:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tc9x7-0000JN-Pk; Sun, 26 Jan 2025 16:13:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tc9x5-0000HL-CF for qemu-devel@nongnu.org; Sun, 26 Jan 2025 16:13:55 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tc9x3-0007cz-H6 for qemu-devel@nongnu.org; Sun, 26 Jan 2025 16:13:55 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-216426b0865so60921425ad.0 for ; Sun, 26 Jan 2025 13:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737926031; x=1738530831; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M9kpcRwj4XMG8ftG4wmZyZnxF1iU/ErySCW5MvOqlTU=; b=zdBYWagp9hSeDHJac3Tylk/CZ0NJAHrYYQmgphgN5UOt7kzvEdhqKUHjDFAbKSpe+f zFv+4Nehw2N8HsWfYDTrUTO+w7Ae4ORgPj02f6zgJin6yfzUqiOIwmb9CepmfdZ2hOQq 1KMYYbLkDwOIMwqJfoI/TRTd22QZ0GsF2qyxvi3Z0oXjP/kpwT4TQQHmfdVABCyRsjYg SOAM3/G9HPxKEYixhQfmxJq65pn9Z1TXMX2eHXvDtHTbgcSpZpqnMGOyu22yZQ45yHCE U9RgaKT/BvZ6pX6TYBQcrcGb/6zBiZlkwUorYO4YjyFxXBESZJls1MLY8hlrgxg2w7Cg sHWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737926031; x=1738530831; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M9kpcRwj4XMG8ftG4wmZyZnxF1iU/ErySCW5MvOqlTU=; b=dhwh5Gh9lkd18uGhBQrJXOp/Tm40yc/p3fq8WsOEBMGf3ZxctOphLrD1ZUbSnXkUbQ pcTU0Lz930b9zFfAf/0Zx9Weu8EBowrgoqpFsWfkH3OzZXvBFmtTZoKdYe6Dl28G+bGU CWELVWiOTDlmz7rNGdRDcBI6p10QbrVq9qdjH140nltbiK9MXrI/yYTFCuZFX/Ku7rY8 I8UqBRKk+uYsQcy6m87Z+AE+xvNmlxCOJINsUQTMmHlszvaPYJK011C0qdfbk/4WQC5M HhFxsrngLQTTMhR9kugRW452nQfwwIm/E9HTgchwc/62E8ORHYS7WgI+Ag4iBVO8doHu sIhQ== X-Forwarded-Encrypted: i=1; AJvYcCV7HRxvQFbG0MGgppDnCLgJ0rNMGKR9U/MC/wQHoWMrn+jBS+K+GoLfcm2VujLGHP/B5KEI5YIO1aNo@nongnu.org X-Gm-Message-State: AOJu0YzrRCYHMjkwH7WwFZamFcWzsjtYaZg1GHhSukJnqZxQtdal80ax XK/KwEGbelhwX+tFNNE4qZQn1hG81DWX9oJ+oP3aneNtuZa/JOBjmMBVPg+w4Zw= X-Gm-Gg: ASbGnctUR8YHE8dETcI3YxIdPRtddP2qqtaulXgi0TOaTvhCb1NTVdkI2zN3pOFTsUp 5HhVQGWcJS2C0SyA21bkGOyVSgO07ZnmNW5AkoV21utFP7MflXElhrDV9KlnVq42xZp/j1MLOJq RO+6xYqez3ctGSc1+Fsw19aWDQA6AXpu+fnlwuXMmMPRfSgWd5FKREcSO5hqQB3HF+S7nNK1wNf Xg67ZitzqEmRMLmK93EZ/unM71xvypjRj79fWxTQvA0BO2114Rb8K3jGvKYP8oaC6lRJO9DVFKs +lkmxJygBNz0tUdFrAKseRvCiqnw+kzL92OB+vYi17JzjAw= X-Google-Smtp-Source: AGHT+IEZs0zeKB5IzyrVqsgjZQ8Qgr6yuUndfoZR9xIIrSSkISsRSLWzsvON9msLe4CFxT+Ly8wqnw== X-Received: by 2002:a17:902:f551:b0:215:431f:268a with SMTP id d9443c01a7336-21c3556016amr565306785ad.31.1737926031507; Sun, 26 Jan 2025 13:13:51 -0800 (PST) Received: from [192.168.0.4] (174-21-71-127.tukw.qwest.net. [174.21.71.127]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da3ea3bb9sm50157355ad.92.2025.01.26.13.13.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2025 13:13:51 -0800 (PST) Message-ID: Date: Sun, 26 Jan 2025 13:13:49 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/20] accel/tcg: Move cpu_memory_rw_debug() user implementation to user-exec.c To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , qemu-arm@nongnu.org, Igor Mammedov , =?UTF-8?Q?Alex_Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, David Hildenbrand , qemu-s390x@nongnu.org, xen-devel@lists.xenproject.org References: <20250123234415.59850-1-philmd@linaro.org> <20250123234415.59850-15-philmd@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <20250123234415.59850-15-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/23/25 15:44, Philippe Mathieu-Daudé wrote: > cpu_memory_rw_debug() system implementation is defined in > system/physmem.c. Move the user one to accel/tcg/user-exec.c > to simplify cpu-target.c maintenance. > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/tcg/user-exec.c | 92 +++++++++++++++++++++++++++++++++++++ > cpu-target.c | 102 +----------------------------------------- > 2 files changed, 94 insertions(+), 100 deletions(-) > > diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c > index c4454100ad7..e7e99a46087 100644 > --- a/accel/tcg/user-exec.c > +++ b/accel/tcg/user-exec.c > @@ -19,6 +19,8 @@ > #include "qemu/osdep.h" > #include "accel/tcg/cpu-ops.h" > #include "disas/disas.h" > +#include "exec/vaddr.h" > +#include "exec/tswap.h" > #include "exec/exec-all.h" > #include "tcg/tcg.h" > #include "qemu/bitops.h" > @@ -35,6 +37,7 @@ > #include "internal-common.h" > #include "internal-target.h" > #include "tb-internal.h" > +#include "qemu.h" What is required from *-user/qemu.h? We really should not be including that in accel/tcg/. > + if (flags & PAGE_WRITE) { > + /* XXX: this code should not depend on lock_user */ > + p = lock_user(VERIFY_WRITE, addr, l, 0); Ah, here it is, complete with comment. Indeed, I don't think lock_user is required at all. page_get_flags() and g2h() are sufficient. > + mmap_lock(); > + tb_invalidate_phys_range(addr, addr + l - 1); > + written = pwrite(fd, buf, l, > + (off_t)(uintptr_t)g2h_untagged(addr)); > + mmap_unlock(); We probably want to own mmap_lock for the entire function. r~