From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/7] tcg/tcg-op: Document bswap16() byte pattern
Date: Wed, 23 Aug 2023 00:04:29 +0200 [thread overview]
Message-ID: <c845cfaa-e529-8260-9793-33cd33a7d1b8@linaro.org> (raw)
In-Reply-To: <408ba512-b15c-5284-8598-6653293a8f51@linaro.org>
On 22/8/23 19:29, Richard Henderson wrote:
> On 8/22/23 10:22, Philippe Mathieu-Daudé wrote:
>> } else {
>> tcg_gen_shli_i32(t1, arg, 8); /* t1 = xab. (IZ=0) */
>> /* .ab. (IZ=1) */
>> }
>>
>> tcg_gen_or_i32(ret, t0, t1); /* ret = ..ba (IZ=1 or
>> OZ=1) */
>> /* = ssba
>> (OS=1) */
>> /* = xxba (no
>> flag) */
>
> Clearer with xaba for no flag?
Right :)
> Otherwise it looks ok.
Thanks!
next prev parent reply other threads:[~2023-08-22 22:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 9:37 [PATCH 0/7] tcg: Document *swap/deposit helpers Philippe Mathieu-Daudé
2023-08-22 9:37 ` [PATCH 1/7] tcg/tcg-op: Document bswap16() byte pattern Philippe Mathieu-Daudé
2023-08-22 15:58 ` Richard Henderson
2023-08-22 17:22 ` Philippe Mathieu-Daudé
2023-08-22 17:29 ` Richard Henderson
2023-08-22 22:04 ` Philippe Mathieu-Daudé [this message]
2023-08-22 9:37 ` [PATCH 2/7] tcg/tcg-op: Document bswap32() " Philippe Mathieu-Daudé
2023-08-22 16:00 ` Richard Henderson
2023-08-23 13:14 ` Philippe Mathieu-Daudé
2023-08-23 15:54 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 3/7] tcg/tcg-op: Document bswap64() " Philippe Mathieu-Daudé
2023-08-22 16:00 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 4/7] tcg/tcg-op: Document hswap() " Philippe Mathieu-Daudé
2023-08-22 16:02 ` Richard Henderson
2023-08-22 16:04 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 5/7] tcg/tcg-op: Document wswap() " Philippe Mathieu-Daudé
2023-08-22 16:03 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 6/7] tcg/tcg-op: Document deposit_z() Philippe Mathieu-Daudé
2023-08-22 16:05 ` Richard Henderson
2023-08-22 9:37 ` [PATCH 7/7] target/cris: Fix a typo in gen_swapr() Philippe Mathieu-Daudé
2023-08-22 13:42 ` [PATCH 0/7] tcg: Document *swap/deposit helpers Alex Bennée
2023-08-22 13:58 ` Peter Maydell
2023-08-22 14:43 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c845cfaa-e529-8260-9793-33cd33a7d1b8@linaro.org \
--to=philmd@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).