From: Laurent Vivier <lvivier@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Peter Lieven" <pl@kamp.de>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] oslib: strip trailing '\n' from error_setg() string argument
Date: Tue, 16 May 2017 09:17:15 +0200 [thread overview]
Message-ID: <c84e4ef1-586b-6bb8-0a29-52d14dd7bd81@redhat.com> (raw)
In-Reply-To: <20170516001150.11508-1-f4bug@amsat.org>
On 16/05/2017 02:11, Philippe Mathieu-Daudé wrote:
> spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> util/oslib-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 4d9189e9ef..7ca02f0103 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -447,7 +447,7 @@ void os_mem_prealloc(int fd, char *area, size_t memory, int smp_cpus,
> /* touch pages simultaneously */
> if (touch_all_pages(area, hpagesize, numpages, smp_cpus)) {
> error_setg(errp, "os_mem_prealloc: Insufficient free host memory "
> - "pages available to allocate guest RAM\n");
> + "pages available to allocate guest RAM");
> }
>
> ret = sigaction(SIGBUS, &oldact, NULL);
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2017-05-16 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 0:11 [Qemu-devel] [PATCH] oslib: strip trailing '\n' from error_setg() string argument Philippe Mathieu-Daudé
2017-05-16 0:11 ` [Qemu-devel] [PATCH] coccinelle: fix typo in comment Philippe Mathieu-Daudé
2017-05-16 14:35 ` Eric Blake
2017-05-20 3:34 ` Philippe Mathieu-Daudé
2017-05-16 7:17 ` Laurent Vivier [this message]
2017-05-17 12:48 ` [Qemu-devel] [PATCH] oslib: strip trailing '\n' from error_setg() string argument Stefan Hajnoczi
2017-05-20 3:39 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c84e4ef1-586b-6bb8-0a29-52d14dd7bd81@redhat.com \
--to=lvivier@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).