From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5989C7618A for ; Thu, 16 Mar 2023 07:53:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pciPs-00082u-DD; Thu, 16 Mar 2023 03:52:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pciPl-00082D-0V for qemu-devel@nongnu.org; Thu, 16 Mar 2023 03:52:45 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pciPf-0007lm-3t for qemu-devel@nongnu.org; Thu, 16 Mar 2023 03:52:40 -0400 Received: by mail-wm1-x329.google.com with SMTP id p16so559581wmq.5 for ; Thu, 16 Mar 2023 00:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678953157; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BTrmkopY2tQw1IttF9YHuZpiFo3j08F1TAzT3W1WWLs=; b=ET4IWYg6r3Oq5oLFxoBSlMsnhxN/kQq9AGrfhYR8P5aojkorPurccZINch0Ai1UDek ulWz6p2z/E76JW/tbPIAJIhAVWaioUHwyrjR2Q3ykp6RLh9HCxFn5UFT6IQyZ3A+HkY1 Vc4Kgh6pAkXTbLXMURWGRvjNu+7BckvZgAe3pUg0FB/4bFxhMFqEJaXhDzXwnFsfVUaY 6i6aGrP0DbOuIsY5fn2lex5v6VDFLl/Gun5JNp6NQDImaur9gnlcLo5i1oZH1lwzrSxD QX8E9V/mX6w56cB47oJX15IfL/0HMx8jd43RtZb3nCqJ2qIPipvVyUkIFdUCJ0D2xZi+ gcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678953157; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BTrmkopY2tQw1IttF9YHuZpiFo3j08F1TAzT3W1WWLs=; b=7VD4C/KBaLfZGOgsJvxc4FTpGLd5p9fxVfvjWw5rRPOr/Q2B6p8FhRFCRnRmc9lBKj TzeRI3N5A/zaBFOgNZrBI6BDQLzdbYWlGiOwrchdPcgbXhyr4jeI9fQoOwW21pOSznZ0 rdjQ+VAvZVLFahts2VXBUAA7YIEej5VBzrQxTn75DzgEzd066V+8f3VrS0nkNvpyJpBv vQCCqJGJV6tCtTBqT/ZH9C6nNoDRijB+4RcLzKfhV8jdErfWYFfBer5uSSEqG0rTEh+Y 8bATg0/Ox4j+kaw2OJoXnpJa1fcN1d4kTjzuQBJWnrsNY2P2Y5hy5MyRgVL0mQRBd1Yj LAkw== X-Gm-Message-State: AO0yUKVE/vSRhH/ebw4rzRPKb82gY0N+neaMprP5LakVEAmsg5/262ey Kgxg8+HV4RwSigDv9/w5azmXxg== X-Google-Smtp-Source: AK7set8/rWMpEXkBEaOJ0Ot+5pSA6ffLtoEqf2nm6yCpG+VyNMGhN5v7AH5OJlYCv9XeIGRvs/Emsg== X-Received: by 2002:a05:600c:3591:b0:3e2:1dac:b071 with SMTP id p17-20020a05600c359100b003e21dacb071mr16915340wmq.13.1678953157301; Thu, 16 Mar 2023 00:52:37 -0700 (PDT) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id t14-20020a05600c198e00b003ed29899dfdsm4361354wmq.21.2023.03.16.00.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 00:52:36 -0700 (PDT) Message-ID: Date: Thu, 16 Mar 2023 08:52:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu Content-Language: en-US To: Ilya Leoshkevich , Yoshinori Sato , Peter Maydell Cc: qemu-devel@nongnu.org, QEMU Trivial References: <20230316003411.129462-1-iii@linux.ibm.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230316003411.129462-1-iii@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 16/3/23 01:34, Ilya Leoshkevich wrote: > When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored. > Fix by using qemu_fprintf() instead of qemu_printf() in the respective > places. > > Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints") > Reviewed-by: Peter Maydell > Reviewed-by: Yoshinori Sato > Signed-off-by: Ilya Leoshkevich > --- > > Resend of https://patchew.org/QEMU/20220725142854.177451-1-iii@linux.ibm.com/ > with a trivial rebase. > > target/sh4/translate.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé