From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu/int128: Re-shuffle Int128Alias members
Date: Tue, 2 May 2023 11:30:19 +0100 [thread overview]
Message-ID: <c861f41a-1342-f792-4b48-250fc68f10dc@linaro.org> (raw)
In-Reply-To: <87h6svt95r.fsf@linaro.org>
On 5/2/23 09:44, Alex Bennée wrote:
>
> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> Clang 14, with --enable-tcg-interpreter errors with
>>
>> include/qemu/int128.h:487:16: error: alignment of field 'i' (128 bits)
>> does not match the alignment of the first field in transparent union;
>> transparent_union attribute ignored [-Werror,-Wignored-attributes]
>> __int128_t i;
>> ^
>> include/qemu/int128.h:486:12: note: alignment of first field is 64 bits
>> Int128 s;
>> ^
>> 1 error generated.
>>
>> By placing the __uint128_t member first, this is avoided.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
Queued to tcg-next.
r~
prev parent reply other threads:[~2023-05-02 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 20:46 [PATCH] qemu/int128: Re-shuffle Int128Alias members Richard Henderson
2023-05-02 8:44 ` Alex Bennée
2023-05-02 10:30 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c861f41a-1342-f792-4b48-250fc68f10dc@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).