From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB566C43218 for ; Mon, 10 Jun 2019 20:09:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAD0D20684 for ; Mon, 10 Jun 2019 20:09:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SwvWMMOv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAD0D20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haQcA-0001d2-Vi for qemu-devel@archiver.kernel.org; Mon, 10 Jun 2019 16:09:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38792) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haQbg-0001DI-Jz for qemu-devel@nongnu.org; Mon, 10 Jun 2019 16:09:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haQbf-0007wC-OS for qemu-devel@nongnu.org; Mon, 10 Jun 2019 16:09:28 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:35745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haQbf-0007vc-DC for qemu-devel@nongnu.org; Mon, 10 Jun 2019 16:09:27 -0400 Received: by mail-pl1-x641.google.com with SMTP id p1so4087234plo.2 for ; Mon, 10 Jun 2019 13:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bPn1S4iNvMfWX8YAvlbnC/CV1rIJFFMUVUp7USfN5Y8=; b=SwvWMMOvsNqV3C1UZDOnFRfgzPk7NoCvLCto0LLfCe345lYvYj468hU9wMTuKrVSrH oXjshUXjktDSr3/qKu/aOVLn5E5d7d3pSZEMDQ/5JBk2/rAfV/DDybwAfkxd5n/z53nY m0MEyjZv7QdBRS/30QfIZ2Sf2O9tttko/vyN53pAxqbgXqiC6w1BHIa9YhrDZ3Zq6Puc jX+oqaPnAPehMjTUBzN2o/FI5T+x/ZOEdFHJ6boAzbm22Z229/q4FcWA9uKyNsbmxglr Zk5jlOLLJU0ztUK2fmTNXMkHZWXtmr3Hw7kc+pJbfFG87r5s8OmRHVx/hFJn0nMAA6hT 8RGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bPn1S4iNvMfWX8YAvlbnC/CV1rIJFFMUVUp7USfN5Y8=; b=cLn/APxbgJE1LB/+p2pdDTcNz9wsV+IaRW0NPKaCj6Sc8FB1Rn33TlCnFkByhpXJIu hw9uX+HVnH7imoTwkmsCNocz+6Qb0iDVIdBXOzhb3Nc9yoVvZ/tXQLVOHCWB+JKSLSZ0 81WLej7yGeXk9OrZgpUFhM7WK74Av32XRYKm/zS4RwNycRWgUJEzgg9v/GWfhS5va7dZ QOb/gH8ql0H8Wx52c3e9ZjKJvjyzK+1yRZon0VNh8pqgECf+P47waKnVtVWrDFUfBBdk CbEJKxkzVK1n8KF9DHPzAq7VnrZQBvzaCf+u6+qKyY9uva0weKHcmDNSpIUJncSo+T+f O8Fw== X-Gm-Message-State: APjAAAUnSlEEcXUNU250EHyFnZg/1maBoZTKcekI/uveM1wgJPJ8ldkv LLewIMebV0JOy9M4xtTkUhlRbw== X-Google-Smtp-Source: APXvYqzzHo57nuAimr2e2UFlYSmIDyivsYxcsIpBT4w2S2pL3NdIvSH8GtH0dmjNQUXlNWUPOFMTkg== X-Received: by 2002:a17:902:20ec:: with SMTP id v41mr68262734plg.142.1560197366139; Mon, 10 Jun 2019 13:09:26 -0700 (PDT) Received: from [192.168.1.11] (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id o20sm9831971pgj.70.2019.06.10.13.09.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2019 13:09:25 -0700 (PDT) To: Michael Rolnik , qemu-devel@nongnu.org References: <20190606193012.37715-1-mrolnik@gmail.com> <20190606193012.37715-5-mrolnik@gmail.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Mon, 10 Jun 2019 13:09:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190606193012.37715-5-mrolnik@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/6/19 12:30 PM, Michael Rolnik wrote: > + target_long cpc; > + target_long npc; CPC gets copied back and forth to NPC, but is now otherwise unused. You can drop that. > +static void translate(DisasContext *ctx) > +{ > + uint32_t opcode; > + int res; > + /* PC points to words. */ > + opcode = cpu_ldl_code(ctx->env, ctx->cpc * 2) & 0x0000ffff; > + > + ctx->npc = ctx->cpc + 1; Which allows this to become uint32_t opcode = next_word(ctx); r~